Re: [PR] feat: A new port is added for prometheus collection, and the indicator init… [incubator-pegasus]

["acelyc111 (via GitHub)" <gi...@apache.org>]

acelyc111 commented on code in PR #1826:
URL: https://github.com/apache/incubator-pegasus/pull/1826#discussion_r1441624630


##########
collector/main.go:
##########
@@ -26,9 +26,12 @@ import (
 	"strings"
 	"syscall"
 
-	"github.com/pegasus-kv/collector/avail"
-	"github.com/pegasus-kv/collector/metrics"
-	"github.com/pegasus-kv/collector/webui"
+	// "github.com/pegasus-kv/collector/avail"
+	// "github.com/pegasus-kv/collector/metrics"
+	// "github.com/pegasus-kv/collector/webui"
+	"github.com/limowang/incubator-pegasus/collector/avail"

Review Comment:
   Remove the comments and use the apache repository.



##########
collector/main:
##########


Review Comment:
   Don't add binaries to the codebase.



##########
collector/webui/webserver.go:
##########
@@ -53,9 +56,22 @@ func StartWebServer() {
 	app.RegisterView(tmpl)
 
 	go func() {
-		err := app.Listen(":8080")
+		err := app.Listen(":8081")

Review Comment:
   It would be better to read from config file or command line rather than hard code.
   
   The port should be user-defined to avoid port conflicts in user environments.



##########
collector/main.go:
##########
@@ -81,7 +84,8 @@ func main() {
 		return
 	}
 
-	webui.StartWebServer()
+	metrics.InitMetrics()
+	//webui.StartWebServer()

Review Comment:
   Just remove it if it's not needed.



##########
collector/metrics/metric_collector.go:
##########
@@ -167,17 +149,15 @@ func initMetrics() {
 						Help: desc,
 					}, []string{"endpoint", "role", "level", "title"})
 					GaugeMetricsMap[name] = *gaugeMetric
-				case "Percentile":
-					if _, ok := SummaryMetricsMap[name]; ok {
+				case "Percentile": //这个需要改动不能用这个表示,用gauge来表示分位数  --level(p50,p99),title(task_name)来替代区分

Review Comment:
   Use English because this is a globally open-source project.



##########
collector/go.mod:
##########
@@ -15,7 +15,7 @@
 // specific language governing permissions and limitations
 // under the License.
 
-module github.com/pegasus-kv/collector
+module github.com/limowang/incubator-pegasus/collector

Review Comment:
   ```suggestion
   module github.com/apache/incubator-pegasus/collector
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org