You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ro...@apache.org on 2007/08/26 18:51:41 UTC

svn commit: r569839 - in /jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn: DefaultClientConnection.java DefaultClientConnectionOperator.java

Author: rolandw
Date: Sun Aug 26 09:51:40 2007
New Revision: 569839

URL: http://svn.apache.org/viewvc?rev=569839&view=rev
Log:
use AbstractHttpClientConnection lineParser and lineFormatter instead of local attributes

Modified:
    jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/DefaultClientConnection.java
    jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/DefaultClientConnectionOperator.java

Modified: jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/DefaultClientConnection.java
URL: http://svn.apache.org/viewvc/jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/DefaultClientConnection.java?rev=569839&r1=569838&r2=569839&view=diff
==============================================================================
--- jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/DefaultClientConnection.java (original)
+++ jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/DefaultClientConnection.java Sun Aug 26 09:51:40 2007
@@ -43,7 +43,6 @@
 import org.apache.http.HttpRequest;
 import org.apache.http.HttpResponse;
 import org.apache.http.HttpResponseFactory;
-import org.apache.http.message.LineParser;
 import org.apache.http.params.HttpParams;
 import org.apache.http.impl.SocketHttpClientConnection;
 import org.apache.http.io.HttpMessageParser;
@@ -81,9 +80,6 @@
     /** Whether this connection is secure. */
     private boolean connSecure;
 
-    /** The line parser to use, or <code>null</code> for the default parser. */
-    private LineParser lineParser;
-
 
     // public default constructor
 
@@ -134,26 +130,6 @@
 
     } // shutdown
 
-
-    /**
-     * Obtains the line parser to be used for receiving messages.
-     *
-     * @return  the line parser, or <code>null</code> for the default
-     */
-    public LineParser getParser() {
-        return lineParser;
-    }
-
-    /**
-     * Specifies the line parser to use when receiving messages.
-     *
-     * @param parser    the line parser to use, or
-     *                  <code>null</code> for the default
-     */
-    public final void setParser(LineParser parser) {
-        lineParser = parser;
-    }
-
     
     public void close() throws IOException {
         LOG.debug("Connection closed");
@@ -196,7 +172,7 @@
             final HttpResponseFactory responseFactory, 
             final HttpParams params) {
         return new DefaultResponseParser
-            (buffer, lineParser, responseFactory, params);
+            (buffer, getLineParser(), responseFactory, params);
     }
 
 

Modified: jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/DefaultClientConnectionOperator.java
URL: http://svn.apache.org/viewvc/jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/DefaultClientConnectionOperator.java?rev=569839&r1=569838&r2=569839&view=diff
==============================================================================
--- jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/DefaultClientConnectionOperator.java (original)
+++ jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/DefaultClientConnectionOperator.java Sun Aug 26 09:51:40 2007
@@ -96,7 +96,7 @@
      *
      * @return  the line parser, or <code>null</code> for the default
      */
-    public LineParser getParser() {
+    public LineParser getLineParser() {
         return lineParser;
     }
 
@@ -106,7 +106,7 @@
      *
      * @param parser    the line parser, or <code>null</code> for the default
      */
-    public void setParser(LineParser parser) {
+    public void setLineParser(LineParser parser) {
         lineParser = parser;
     }
 
@@ -114,7 +114,7 @@
     // non-javadoc, see interface ClientConnectionOperator
     public OperatedClientConnection createConnection() {
         DefaultClientConnection dcc = new DefaultClientConnection();
-        dcc.setParser(lineParser);
+        dcc.setLineParser(lineParser);
         return dcc;
     }