You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "tchughesiv (via GitHub)" <gi...@apache.org> on 2024/02/08 19:54:23 UTC
[PR] [380] enhance SonataFlowClusterPlatform.spec [incubator-kie-kogito-serverless-operator]
tchughesiv opened a new pull request, #389:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/389
<!--
Welcome to the SonataFlow Operator! Before contributing, make sure to:
- Rebase your branch on the latest upstream main
- Link any relevant issues, PR's, or documentation
- Check that the commit message is concise and helpful:
- When fixing an issue, add "Closes #<ISSUE_NUMBER>"
- Follow the below checklist
-->
**Description of the change:**
Enhance SonataFlowClusterPlatform.spec to better communicate which capabilities are used by workflows cluster-wide. Adds `capabilities.workflow["services"]` to `spec`.
```yaml
apiVersion: sonataflow.org/v1alpha08
kind: SonataFlowClusterPlatform
metadata:
name: cluster-platform
spec:
platformRef:
name: sonataflow-platform
namespace: central-platform-ns
capabilities:
workflow:
- services
```
**Motivation for the change:**
fixes https://github.com/apache/incubator-kie-kogito-serverless-operator/issues/380
**Checklist**
- [ ] Add or Modify a unit test for your change
- [ ] Have you verified that tall the tests are passing?
<details>
<summary>
How to backport a pull request to a different branch?
</summary>
In order to automatically create a **backporting pull request** please add one or more labels having the following format `backport-<branch-name>`, where `<branch-name>` is the name of the branch where the pull request must be backported to (e.g., `backport-7.67.x` to backport the original PR to the `7.67.x` branch).
> **NOTE**: **backporting** is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.
Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.
> **NOTE**: this automated backporting is triggered whenever a pull request on `main` branch is labeled or closed, but both conditions must be satisfied to get the new PR created.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [380] enhance SonataFlowClusterPlatform.spec [incubator-kie-kogito-serverless-operator]
Posted by "jordigilh (via GitHub)" <gi...@apache.org>.
jordigilh commented on code in PR #389:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/389#discussion_r1496779300
##########
test/e2e/clusterplatform_test.go:
##########
@@ -0,0 +1,159 @@
+// Copyright 2024 Apache Software Foundation (ASF)
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package e2e
+
+import (
+ //nolint:golint
+ //nolint:revive
+
+ "bytes"
+ "fmt"
+ "math/rand"
+ "os/exec"
+ "path/filepath"
+ "time"
+
+ "github.com/apache/incubator-kie-kogito-serverless-operator/controllers/platform/services"
+ "github.com/apache/incubator-kie-kogito-serverless-operator/controllers/profiles/common/constants"
+ "github.com/apache/incubator-kie-kogito-serverless-operator/test"
+ "github.com/apache/incubator-kie-kogito-serverless-operator/test/utils"
+
+ //nolint:golint
+ //nolint:revive
+ . "github.com/onsi/ginkgo/v2"
+
+ //nolint:golint
+ //nolint:revive
+ . "github.com/onsi/gomega"
+)
+
+var _ = Describe("Validate a clusterplatform", Ordered, func() {
+
+ var (
+ projectDir string
+ targetNamespace string
+ targetNamespace2 string
+ )
+
+ BeforeEach(func() {
+ targetNamespace = fmt.Sprintf("test-%d", rand.Intn(1024)+1)
+ cmd := exec.Command("kubectl", "create", "namespace", targetNamespace)
+ _, err := utils.Run(cmd)
+ Expect(err).NotTo(HaveOccurred())
+
+ targetNamespace2 = fmt.Sprintf("test-%d", rand.Intn(1024)+1)
+ cmd = exec.Command("kubectl", "create", "namespace", targetNamespace2)
+ _, err = utils.Run(cmd)
+ Expect(err).NotTo(HaveOccurred())
+ })
+ AfterEach(func() {
+ // Remove resources in test namespacs with no failure
+ if !CurrentSpecReport().Failed() {
+ if len(targetNamespace) > 0 {
+ cmd := exec.Command("kubectl", "delete", "namespace", targetNamespace, "--wait")
+ _, err := utils.Run(cmd)
+ Expect(err).NotTo(HaveOccurred())
+ }
+ if len(targetNamespace2) > 0 {
+ cmd := exec.Command("kubectl", "delete", "namespace", targetNamespace2, "--wait")
+ _, err := utils.Run(cmd)
+ Expect(err).NotTo(HaveOccurred())
+ }
+ }
+ })
+ var _ = Context("with supporting services enabled", func() {
+
+ DescribeTable("against a platform in a separate namespace", func(testcaseDir string, profile string, persistenceType string) {
+ By("Deploy the SonataFlowPlatform CR")
+ var manifests []byte
+ EventuallyWithOffset(1, func() error {
+ var err error
+ cmd := exec.Command("kubectl", "kustomize", filepath.Join(projectDir,
+ test.GetSonataFlowE2EPlatformServicesDirectory(), profile, clusterWideEphemeral))
+ manifests, err = utils.Run(cmd)
+ return err
+ }, time.Minute, time.Second).Should(Succeed())
+
+ cmd := exec.Command("kubectl", "create", "-n", targetNamespace, "-f", "-")
+ cmd.Stdin = bytes.NewBuffer(manifests)
+ _, err := utils.Run(cmd)
+ Expect(err).NotTo(HaveOccurred())
+
+ By("Wait for SonatatFlowPlatform CR in " + targetNamespace + " to be ready")
+ // wait for platform to be ready
+ EventuallyWithOffset(1, func() error {
+ cmd = exec.Command("kubectl", "wait", "sfplatform", "-n", targetNamespace, "sonataflow-platform", "--for", "condition=Succeed", "--timeout=5s")
+ _, err = utils.Run(cmd)
+ return err
+ }, 20*time.Minute, 5).Should(Succeed())
+ EventuallyWithOffset(1, func() []byte {
+ cmd = exec.Command("kubectl", "get", "sfplatform", "-n", targetNamespace, "sonataflow-platform", "-o", "jsonpath='{.status.clusterPlatformRef}'")
+ returnedValue, _ := utils.Run(cmd)
+ println(string(returnedValue))
+ return returnedValue
+ }, 20*time.Minute, 5).Should(Equal([]byte("''")))
+
+ By("Evaluate status of SonataFlowClusterPlatform CR")
+ cmd = exec.Command("kubectl", "patch", "SonataFlowClusterPlatform", "cluster", "--type", "merge", "-p", `{"spec": {"platformRef": {"namespace": "`+targetNamespace+`"}}}`)
+ _, err = utils.Run(cmd)
+ Expect(err).NotTo(HaveOccurred())
+ EventuallyWithOffset(1, func() error {
+ cmd = exec.Command("kubectl", "wait", "SonataFlowClusterPlatform", "cluster", "--for", "condition=Succeed", "--timeout=5s")
+ _, err = utils.Run(cmd)
+ return err
+ }, 20*time.Minute, 5).Should(Succeed())
+
+ EventuallyWithOffset(1, func() error {
+ var err error
+ cmd := exec.Command("kubectl", "kustomize", filepath.Join(projectDir,
+ testcaseDir, profile, persistenceType))
+ manifests, err = utils.Run(cmd)
+ return err
+ }, time.Minute, time.Second).Should(Succeed())
+
+ cmd = exec.Command("kubectl", "create", "-n", targetNamespace2, "-f", "-")
+ cmd.Stdin = bytes.NewBuffer(manifests)
+ _, err = utils.Run(cmd)
+ Expect(err).NotTo(HaveOccurred())
+
+ By("Wait for SonatatFlowPlatform CR in " + targetNamespace2 + " to be ready")
+ dataIndexServiceUrl := services.GenerateServiceURL(constants.KogitoServiceURLProtocol, targetNamespace, "sonataflow-platform-"+constants.DataIndexServiceName)
+ jobServiceUrl := services.GenerateServiceURL(constants.KogitoServiceURLProtocol, targetNamespace, "sonataflow-platform-"+constants.JobServiceName)
+ // wait for platform to be ready
+ EventuallyWithOffset(1, func() error {
+ cmd = exec.Command("kubectl", "wait", "sfplatform", "-n", targetNamespace2, "sonataflow-platform", "--for", "condition=Succeed", "--timeout=5s")
+ _, err = utils.Run(cmd)
+ return err
+ }, 20*time.Minute, 5).Should(Succeed())
+ EventuallyWithOffset(1, func() []byte {
+ cmd = exec.Command("kubectl", "get", "sfplatform", "-n", targetNamespace2, "sonataflow-platform", "-o", "jsonpath='{.status.clusterPlatformRef.services.dataIndexRef.url}'")
+ returnedValue, _ := utils.Run(cmd)
+ return returnedValue
+ }, 20*time.Minute, 5).Should(Equal([]byte("'" + dataIndexServiceUrl + "'")))
+ EventuallyWithOffset(1, func() []byte {
+ cmd = exec.Command("kubectl", "get", "sfplatform", "-n", targetNamespace2, "sonataflow-platform", "-o", "jsonpath='{.status.clusterPlatformRef.services.jobServiceRef.url}'")
+ returnedValue, _ := utils.Run(cmd)
+ return returnedValue
+ }, 20*time.Minute, 5).Should(Equal([]byte("'" + jobServiceUrl + "'")))
+
+ cmd = exec.Command("kubectl", "delete", "SonataFlowClusterPlatform", "cluster", "--wait")
+ _, err = utils.Run(cmd)
+ Expect(err).NotTo(HaveOccurred())
+ },
+ Entry("without services configured", test.GetSonataFlowE2EPlatformNoServicesDirectory(), dev, ephemeral),
Review Comment:
Do you think it's worth covering additional use cases, for instance when one of the services is already provided in the target namespace, or when both are?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [380] enhance SonataFlowClusterPlatform.spec [incubator-kie-kogito-serverless-operator]
Posted by "tchughesiv (via GitHub)" <gi...@apache.org>.
tchughesiv commented on PR #389:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/389#issuecomment-1953200826
> @tchughesiv any plans to add E2E tests to this PR? So far there are none for this controller.
@jordigilh @ricardozanini should i add them to this PR or a separate one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [380] enhance SonataFlowClusterPlatform.spec [incubator-kie-kogito-serverless-operator]
Posted by "jordigilh (via GitHub)" <gi...@apache.org>.
jordigilh commented on PR #389:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/389#issuecomment-1952977960
@tchughesiv any plans to add E2E tests to this PR? So far there are none for this controller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [380] enhance SonataFlowClusterPlatform.spec [incubator-kie-kogito-serverless-operator]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on PR #389:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/389#issuecomment-1952328376
@wmedvede we can't preview the future atm, @wmedvede. But the core engine is already based on those capabilities in the form of Quarkus extensions. So, for instance, I can see cluster-level messaging, persistence, monitoring, and so on in the future. So leaving the API capable of accommodating those is the intention of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [380] enhance SonataFlowClusterPlatform.spec [incubator-kie-kogito-serverless-operator]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on PR #389:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/389#issuecomment-1969090316
@tchughesiv can you please rebase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [380] enhance SonataFlowClusterPlatform.spec [incubator-kie-kogito-serverless-operator]
Posted by "tchughesiv (via GitHub)" <gi...@apache.org>.
tchughesiv commented on code in PR #389:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/389#discussion_r1498352940
##########
test/e2e/clusterplatform_test.go:
##########
@@ -0,0 +1,159 @@
+// Copyright 2024 Apache Software Foundation (ASF)
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package e2e
+
+import (
+ //nolint:golint
+ //nolint:revive
+
+ "bytes"
+ "fmt"
+ "math/rand"
+ "os/exec"
+ "path/filepath"
+ "time"
+
+ "github.com/apache/incubator-kie-kogito-serverless-operator/controllers/platform/services"
+ "github.com/apache/incubator-kie-kogito-serverless-operator/controllers/profiles/common/constants"
+ "github.com/apache/incubator-kie-kogito-serverless-operator/test"
+ "github.com/apache/incubator-kie-kogito-serverless-operator/test/utils"
+
+ //nolint:golint
+ //nolint:revive
+ . "github.com/onsi/ginkgo/v2"
+
+ //nolint:golint
+ //nolint:revive
+ . "github.com/onsi/gomega"
+)
+
+var _ = Describe("Validate a clusterplatform", Ordered, func() {
+
+ var (
+ projectDir string
+ targetNamespace string
+ targetNamespace2 string
+ )
+
+ BeforeEach(func() {
+ targetNamespace = fmt.Sprintf("test-%d", rand.Intn(1024)+1)
+ cmd := exec.Command("kubectl", "create", "namespace", targetNamespace)
+ _, err := utils.Run(cmd)
+ Expect(err).NotTo(HaveOccurred())
+
+ targetNamespace2 = fmt.Sprintf("test-%d", rand.Intn(1024)+1)
+ cmd = exec.Command("kubectl", "create", "namespace", targetNamespace2)
+ _, err = utils.Run(cmd)
+ Expect(err).NotTo(HaveOccurred())
+ })
+ AfterEach(func() {
+ // Remove resources in test namespacs with no failure
+ if !CurrentSpecReport().Failed() {
+ if len(targetNamespace) > 0 {
+ cmd := exec.Command("kubectl", "delete", "namespace", targetNamespace, "--wait")
+ _, err := utils.Run(cmd)
+ Expect(err).NotTo(HaveOccurred())
+ }
+ if len(targetNamespace2) > 0 {
+ cmd := exec.Command("kubectl", "delete", "namespace", targetNamespace2, "--wait")
+ _, err := utils.Run(cmd)
+ Expect(err).NotTo(HaveOccurred())
+ }
+ }
+ })
+ var _ = Context("with supporting services enabled", func() {
+
+ DescribeTable("against a platform in a separate namespace", func(testcaseDir string, profile string, persistenceType string) {
+ By("Deploy the SonataFlowPlatform CR")
+ var manifests []byte
+ EventuallyWithOffset(1, func() error {
+ var err error
+ cmd := exec.Command("kubectl", "kustomize", filepath.Join(projectDir,
+ test.GetSonataFlowE2EPlatformServicesDirectory(), profile, clusterWideEphemeral))
+ manifests, err = utils.Run(cmd)
+ return err
+ }, time.Minute, time.Second).Should(Succeed())
+
+ cmd := exec.Command("kubectl", "create", "-n", targetNamespace, "-f", "-")
+ cmd.Stdin = bytes.NewBuffer(manifests)
+ _, err := utils.Run(cmd)
+ Expect(err).NotTo(HaveOccurred())
+
+ By("Wait for SonatatFlowPlatform CR in " + targetNamespace + " to be ready")
+ // wait for platform to be ready
+ EventuallyWithOffset(1, func() error {
+ cmd = exec.Command("kubectl", "wait", "sfplatform", "-n", targetNamespace, "sonataflow-platform", "--for", "condition=Succeed", "--timeout=5s")
+ _, err = utils.Run(cmd)
+ return err
+ }, 20*time.Minute, 5).Should(Succeed())
+ EventuallyWithOffset(1, func() []byte {
+ cmd = exec.Command("kubectl", "get", "sfplatform", "-n", targetNamespace, "sonataflow-platform", "-o", "jsonpath='{.status.clusterPlatformRef}'")
+ returnedValue, _ := utils.Run(cmd)
+ println(string(returnedValue))
+ return returnedValue
+ }, 20*time.Minute, 5).Should(Equal([]byte("''")))
+
+ By("Evaluate status of SonataFlowClusterPlatform CR")
+ cmd = exec.Command("kubectl", "patch", "SonataFlowClusterPlatform", "cluster", "--type", "merge", "-p", `{"spec": {"platformRef": {"namespace": "`+targetNamespace+`"}}}`)
+ _, err = utils.Run(cmd)
+ Expect(err).NotTo(HaveOccurred())
+ EventuallyWithOffset(1, func() error {
+ cmd = exec.Command("kubectl", "wait", "SonataFlowClusterPlatform", "cluster", "--for", "condition=Succeed", "--timeout=5s")
+ _, err = utils.Run(cmd)
+ return err
+ }, 20*time.Minute, 5).Should(Succeed())
+
+ EventuallyWithOffset(1, func() error {
+ var err error
+ cmd := exec.Command("kubectl", "kustomize", filepath.Join(projectDir,
+ testcaseDir, profile, persistenceType))
+ manifests, err = utils.Run(cmd)
+ return err
+ }, time.Minute, time.Second).Should(Succeed())
+
+ cmd = exec.Command("kubectl", "create", "-n", targetNamespace2, "-f", "-")
+ cmd.Stdin = bytes.NewBuffer(manifests)
+ _, err = utils.Run(cmd)
+ Expect(err).NotTo(HaveOccurred())
+
+ By("Wait for SonatatFlowPlatform CR in " + targetNamespace2 + " to be ready")
+ dataIndexServiceUrl := services.GenerateServiceURL(constants.KogitoServiceURLProtocol, targetNamespace, "sonataflow-platform-"+constants.DataIndexServiceName)
+ jobServiceUrl := services.GenerateServiceURL(constants.KogitoServiceURLProtocol, targetNamespace, "sonataflow-platform-"+constants.JobServiceName)
+ // wait for platform to be ready
+ EventuallyWithOffset(1, func() error {
+ cmd = exec.Command("kubectl", "wait", "sfplatform", "-n", targetNamespace2, "sonataflow-platform", "--for", "condition=Succeed", "--timeout=5s")
+ _, err = utils.Run(cmd)
+ return err
+ }, 20*time.Minute, 5).Should(Succeed())
+ EventuallyWithOffset(1, func() []byte {
+ cmd = exec.Command("kubectl", "get", "sfplatform", "-n", targetNamespace2, "sonataflow-platform", "-o", "jsonpath='{.status.clusterPlatformRef.services.dataIndexRef.url}'")
+ returnedValue, _ := utils.Run(cmd)
+ return returnedValue
+ }, 20*time.Minute, 5).Should(Equal([]byte("'" + dataIndexServiceUrl + "'")))
+ EventuallyWithOffset(1, func() []byte {
+ cmd = exec.Command("kubectl", "get", "sfplatform", "-n", targetNamespace2, "sonataflow-platform", "-o", "jsonpath='{.status.clusterPlatformRef.services.jobServiceRef.url}'")
+ returnedValue, _ := utils.Run(cmd)
+ return returnedValue
+ }, 20*time.Minute, 5).Should(Equal([]byte("'" + jobServiceUrl + "'")))
+
+ cmd = exec.Command("kubectl", "delete", "SonataFlowClusterPlatform", "cluster", "--wait")
+ _, err = utils.Run(cmd)
+ Expect(err).NotTo(HaveOccurred())
+ },
+ Entry("without services configured", test.GetSonataFlowE2EPlatformNoServicesDirectory(), dev, ephemeral),
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [380] enhance SonataFlowClusterPlatform.spec [incubator-kie-kogito-serverless-operator]
Posted by "tchughesiv (via GitHub)" <gi...@apache.org>.
tchughesiv commented on PR #389:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/389#issuecomment-1955211924
@jordigilh @ricardozanini i've added e2e tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [380] enhance SonataFlowClusterPlatform.spec [incubator-kie-kogito-serverless-operator]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini merged PR #389:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [380] enhance SonataFlowClusterPlatform.spec [incubator-kie-kogito-serverless-operator]
Posted by "jordigilh (via GitHub)" <gi...@apache.org>.
jordigilh commented on PR #389:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/389#issuecomment-1953202579
> > @tchughesiv any plans to add E2E tests to this PR? So far there are none for this controller.
>
> @jordigilh @ricardozanini should i add them to this PR or a separate one?
Any reason for not adding them to this PR already? Perhaps dependencies to other unmerged PRs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [380] enhance SonataFlowClusterPlatform.spec [incubator-kie-kogito-serverless-operator]
Posted by "tchughesiv (via GitHub)" <gi...@apache.org>.
tchughesiv commented on PR #389:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/389#issuecomment-1969184806
@ricardozanini done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [380] enhance SonataFlowClusterPlatform.spec [incubator-kie-kogito-serverless-operator]
Posted by "tchughesiv (via GitHub)" <gi...@apache.org>.
tchughesiv commented on PR #389:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/389#issuecomment-1954571598
> Any reason for not adding them to this PR already? Perhaps dependencies to other unmerged PRs?
@jordigilh let me see what i can do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org