Re: [PR] HIVE-28532 Map Join Reuse cache allows to share hashtables for different join types [hive]

["ramesh0201 (via GitHub)" <gi...@apache.org>]

ramesh0201 commented on code in PR #5462:
URL: https://github.com/apache/hive/pull/5462#discussion_r1900558346


##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -1007,6 +1007,16 @@ private boolean canShareBroadcastInputs(
       return false;
     }
 
+    // Map Joins when vectorized can have different formats for the hash tables built on the small table.
+    // Reusing hash tables between different join type can lead to ClassCastException or even wrong results.
+    if (mapJoinOp1.getConf().getConds() != null && mapJoinOp1.getConf().getConds().length > 0

Review Comment:
   Thank you! Modified this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org