[GitHub] [helix] jiajunwang commented on pull request #1842: Fix TestClusterAggregateMetrics

[GitBox <gi...@apache.org>]

jiajunwang commented on pull request #1842:
URL: https://github.com/apache/helix/pull/1842#issuecomment-904130368


   A better way, or IMHO the correct way, is to wait until the cluster state converged. The main reason we might get unexpected results is that the controller is still rebalancing the cluster while the assert check happens. Given that saying, the current change will reduce the error by reducing pipeline running. But it is not guaranteed since only one pipeline can still run slowly.
   
   Could you please change the test logic to wait until the cluster converges then start validation? Note the verifier should support validate instance state in the call. So you can specify the expected disabled nodes in the same check to ensure verifier does not return prematurely.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org