You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/03/26 09:01:02 UTC
[GitHub] [rocketmq-operator] zhihui921016 opened a new pull request #24: [ISSUE #23] Support for creating multiple brokerClusters with differe…
zhihui921016 opened a new pull request #24: [ISSUE #23] Support for creating multiple brokerClusters with differe…
URL: https://github.com/apache/rocketmq-operator/pull/24
…nt names
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-operator] zhihui921016 commented on issue #24: [ISSUE #23] Support for creating multiple brokerClusters with differe…
Posted by GitBox <gi...@apache.org>.
zhihui921016 commented on issue #24: [ISSUE #23] Support for creating multiple brokerClusters with differe…
URL: https://github.com/apache/rocketmq-operator/pull/24#issuecomment-608215284
@liuruiyiyang In addition, I have tested that the broker cluster can be scaled up normally before submission
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-operator] zhihui921016 commented on issue #24: [ISSUE #23] Support for creating multiple brokerClusters with differe…
Posted by GitBox <gi...@apache.org>.
zhihui921016 commented on issue #24: [ISSUE #23] Support for creating multiple brokerClusters with differe…
URL: https://github.com/apache/rocketmq-operator/pull/24#issuecomment-608193207
@liuruiyiyang When deploying a broekr cluster, scalePodName needs to be prefixed with the broker cluster name. For example, if the name of broker is ‘broker’，the scalePodName is ‘broker-0-master-0’, if the name of broker is ‘cluster’, the scalePodName should be ‘cluster-0-master-0’
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-operator] zhihui921016 closed pull request #24: [ISSUE #23] Support for creating multiple brokerClusters with differe…
Posted by GitBox <gi...@apache.org>.
zhihui921016 closed pull request #24: [ISSUE #23] Support for creating multiple brokerClusters with differe…
URL: https://github.com/apache/rocketmq-operator/pull/24
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-operator] zhihui921016 opened a new pull request #24: [ISSUE #23] Support for creating multiple brokerClusters with differe…
Posted by GitBox <gi...@apache.org>.
zhihui921016 opened a new pull request #24: [ISSUE #23] Support for creating multiple brokerClusters with differe…
URL: https://github.com/apache/rocketmq-operator/pull/24
…nt names
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-operator] zhihui921016 removed a comment on issue #24: [ISSUE #23] Support for creating multiple brokerClusters with differe…
Posted by GitBox <gi...@apache.org>.
zhihui921016 removed a comment on issue #24: [ISSUE #23] Support for creating multiple brokerClusters with differe…
URL: https://github.com/apache/rocketmq-operator/pull/24#issuecomment-608190644
> The original design principle of the `size` field of the CRD Broker means how many broker groups the cluster has. By broker groups, it means one master broker and several replica brokers( could be zero). A broker cluster means several broker groups with the same name prefix. If you want to broke that rule and allow multiple broker cluster exists with different names. I am not sure that in the broker scale up process, whether the operator will normally transmit the metadata from user-defined source broker pod to the new broker, could you please help checked the influence on the scale up process?
>
> Besides, I think it is important to allow different broker cluster exists with different name prefix. To do that we have to clear the related concepts(the relationship of broker group, broker cluster, master, replica, etc.) and make the code consistent with that.
> Thank you very much for your contribution!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-operator] zhihui921016 commented on issue #24: [ISSUE #23] Support for creating multiple brokerClusters with differe…
Posted by GitBox <gi...@apache.org>.
zhihui921016 commented on issue #24: [ISSUE #23] Support for creating multiple brokerClusters with differe…
URL: https://github.com/apache/rocketmq-operator/pull/24#issuecomment-608190644
> The original design principle of the `size` field of the CRD Broker means how many broker groups the cluster has. By broker groups, it means one master broker and several replica brokers( could be zero). A broker cluster means several broker groups with the same name prefix. If you want to broke that rule and allow multiple broker cluster exists with different names. I am not sure that in the broker scale up process, whether the operator will normally transmit the metadata from user-defined source broker pod to the new broker, could you please help checked the influence on the scale up process?
>
> Besides, I think it is important to allow different broker cluster exists with different name prefix. To do that we have to clear the related concepts(the relationship of broker group, broker cluster, master, replica, etc.) and make the code consistent with that.
> Thank you very much for your contribution!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services