You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/21 22:45:34 UTC

[GitHub] [skywalking] kezhenxu94 commented on pull request #6794: feature:Support alarm to WeLink

kezhenxu94 commented on pull request #6794:
URL: https://github.com/apache/skywalking/pull/6794#issuecomment-824412720


   
   > The UT could only test webhook is working, but we have no chance to verify whether WeLink actually works.
   > 
   > @kezhenxu94 Any suggestion? Should we merge this blindly?
   
   When alarm rules are triggered, as long as the webhook request is sent from SkyWalking side I think we’re done, testing whether WeLink works or not after receiving the webhook is beyond our responsibility. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org