[GitHub] [activemq-artemis] MarcoR83 commented on pull request #4040: Allow binary deserialization of message properties AMQ_MSG_MESSAGE_ID…

[GitBox <gi...@apache.org>]

MarcoR83 commented on PR #4040:
URL: https://github.com/apache/activemq-artemis/pull/4040#issuecomment-1106652342

   Alright. Ok  so lets see... 
   
   1. @AntonRoskvist recently added https://github.com/apache/activemq-artemis/commit/32c5f9d2685252e4b5fb213527084173351d7d63 I had a look into it and it does not solve the warning (it is used on inbound OpenWire Messages)
   
   2. Can you clarify what you mean by, "could not be deliverd"? 
   Ok I checked that error handling. True it does not stop the code from proceeding, but the prior existing property gets lost along the way. I dont know what this might imply, as I'm not super into all of this. I just saw the error popping up after upstaging 2.21.0 on our environments. So if this properties are not needed by the OpenWire Clients this could be ignored, but I feel it is still not the greatest way just to ignore. The data was written with an older version and now it wont be recognized anymore. IMHO bad practise for a data broker.
   
   3. Well.. without tests it will be impossible to consider merging this... 
   I will hopefully be able to create  suitable testcases. Would have so see to store Properties the old way and then read them using OpenWire protocol.. Not sure where to start... will have to dive deeper into the code/tests. Will come back with an update.
   
   4.  a JIRA + amend your commit message with your JIRA. 
   So I can/should create an Jira issue? Anything I need to consider when filling out the fields?
   Amend the commit/s with the Jira-key should not be a problem ;) 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org