You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/10 04:32:19 UTC
[GitHub] [apisix-dashboard] jbampton opened a new pull request #1002: Fix spelling
jbampton opened a new pull request #1002:
URL: https://github.com/apache/apisix-dashboard/pull/1002
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] jbampton commented on a change in pull request #1002: fix: spelling
Posted by GitBox <gi...@apache.org>.
jbampton commented on a change in pull request #1002:
URL: https://github.com/apache/apisix-dashboard/pull/1002#discussion_r539932448
##########
File path: api/conf/schema.json
##########
@@ -3217,21 +3217,21 @@
"minProperties": 1,
"properties": {
"body": {
- "description": "new body for repsonse",
+ "description": "new body for response",
Review comment:
Hey @membphis I use various tools like linters, spell checkers and also the find and replace function in my editor 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on a change in pull request #1002: fix: spelling
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1002:
URL: https://github.com/apache/apisix-dashboard/pull/1002#discussion_r539915259
##########
File path: api/conf/schema.json
##########
@@ -3217,21 +3217,21 @@
"minProperties": 1,
"properties": {
"body": {
- "description": "new body for repsonse",
+ "description": "new body for response",
Review comment:
I think we need to update the schema of APISIX too
@jbampton how did you find those problems? Any tools?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis merged pull request #1002: fix: spelling
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #1002:
URL: https://github.com/apache/apisix-dashboard/pull/1002
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org