You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/03/24 21:04:15 UTC
[GitHub] [tvm] tkonolige commented on a change in pull request #10773: [ARM] Fix NCHWc int8 dot product schedule lowering
tkonolige commented on a change in pull request #10773:
URL: https://github.com/apache/tvm/pull/10773#discussion_r834728177
##########
File path: python/tvm/relay/op/strategy/arm_cpu.py
##########
@@ -88,20 +88,21 @@ def conv2d_strategy_arm_cpu(attrs, inputs, out_type, target):
if groups == 1:
if layout == "NCHW":
if kernel_layout == "OIHW":
- # ARM conv2d spatial pack schedule.
- strategy.add_implementation(
- wrap_compute_conv2d(topi.arm_cpu.conv2d_nchw_spatial_pack),
- wrap_topi_schedule(topi.arm_cpu.schedule_conv2d_nchw_spatial_pack),
- name="conv2d_nchw_spatial_pack.arm_cpu",
- )
-
if topi.arm_cpu.is_int8_hw_support(data.dtype, kernel.dtype):
strategy.add_implementation(
wrap_compute_conv2d(topi.arm_cpu.conv2d_nchw_int8),
wrap_topi_schedule(topi.arm_cpu.schedule_conv2d_nchw_int8),
name="conv2d_nchw_int8.arm_cpu",
)
else:
+ # ARM conv2d spatial pack schedule.
+ strategy.add_implementation(
+ wrap_compute_conv2d(topi.arm_cpu.conv2d_nchw_spatial_pack),
+ wrap_topi_schedule(topi.arm_cpu.schedule_conv2d_nchw_spatial_pack),
+ name="conv2d_nchw_spatial_pack.arm_cpu",
+ plevel=10,
+ )
+
Review comment:
Seems like another good argument for removing tophub. You can disable it for the test by putting it all in an empty `ApplyHistoryBest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org