You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by davidschreiber <gi...@git.apache.org> on 2017/05/22 09:55:01 UTC
[GitHub] cordova-plugin-test-framework pull request #24: Add important build step abo...
GitHub user davidschreiber opened a pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/24
Add important build step about packages.json
This step is necessary or tests won't build. The original issue that fixed this issue in all Cordova projects is was only closed recently, but the information was missing in this repository: https://issues.apache.org/jira/browse/CB-12685
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davidschreiber/cordova-plugin-test-framework patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-test-framework/pull/24.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #24
----
commit ec8c77eaf39e53f03b37f4ac68f5abe45634f19c
Author: David Schreiber-Ranner <da...@users.noreply.github.com>
Date: 2017-05-22T09:53:56Z
Add important build step
This step is necessary or tests won't build. The original issue that fixed this issue in all cordova projects is was only closed recently, but the information was missing in this repository: https://issues.apache.org/jira/browse/CB-12685
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-test-framework issue #24: Add important build step about pack...
Posted by davidschreiber <gi...@git.apache.org>.
Github user davidschreiber commented on the issue:
https://github.com/apache/cordova-plugin-test-framework/pull/24
I think this PR is stale by now. Had no time to finish it back then. Also, I can't say if tests still require a `package.json` and if this somewhere documented. I'd suggest you ask the project maintainers, and maybe file an issue if appropriate. Closing this PR.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request #24: Add important build step abo...
Posted by davidschreiber <gi...@git.apache.org>.
Github user davidschreiber closed the pull request at:
https://github.com/apache/cordova-plugin-test-framework/pull/24
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-test-framework issue #24: Add important build step about pack...
Posted by audreyso <gi...@git.apache.org>.
Github user audreyso commented on the issue:
https://github.com/apache/cordova-plugin-test-framework/pull/24
@filmaj Hi! Has this issue been resolved? May I close it?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-test-framework issue #24: Add important build step about pack...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-plugin-test-framework/pull/24
Yup. This is still good info to add to the Readme. Maybe @audreyso can create a new PR adding the info (low priority)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-test-framework issue #24: Add important build step about pack...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-test-framework/pull/24
Ooo, also, could this PR be issued against the master branch? Next time we do a patch release, we will ensure to pull this commit from master into the release branch anyways.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-test-framework issue #24: Add important build step about pack...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-test-framework/pull/24
Ping @stevengill - we might want to still tackle the issue here.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request #24: Add important build step abo...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/24#discussion_r118083583
--- Diff: README.md ---
@@ -63,6 +64,8 @@ For example, the `cordova-plugin-device` plugin has this nested [`plugin.xml`](h
The `cordova-plugin-test-framework` plugin will automatically find all `tests` modules across all plugins for which the nested tests plugin is installed.
+> **Important:** Inside your project's `tests/` folder you also have to create a `package.json`. See the [`package.json` of the `cordova-plugin-device`](https://github.com/apache/cordova-plugin-device/blob/736c7b9dfdfa25a924ffc3d1e409450633a8c00f/tests/package.json) for an example.
--- End diff --
Ah yes, good point. Could I suggest, however, that we reword this a bit and move the paragraph up above the previous "...will automatically find all `tests` modules" paragraph?
In particular, I would structure this paragraph just like the first paragraph in the section, in a similar, instruction-providing way. Explaining _why_ this needs to be done would be a nice touch, too - it would help users understand the intentions behind each requirement. In particular, the latest version of the tools ensure to run `npm install` on any plugin added to a project, to ensure to pull in any dependencies. Therefore, plugin authors can now put npm dependencies around their tests into the `package.json` file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org