[GitHub] [spark] sunchao commented on a change in pull request #29831: [SPARK-32351][SQL] Show partially pushed down partition filters in explain()

[GitBox <gi...@apache.org>]

sunchao commented on a change in pull request #29831:
URL: https://github.com/apache/spark/pull/29831#discussion_r502710169



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -467,13 +468,13 @@ case class DataSourceStrategy(conf: SQLConf) extends Strategy with Logging with
   }
 }
 
-object DataSourceStrategy {
+object DataSourceStrategy extends PredicateHelper {
   /**
    * The attribute name may differ from the one in the schema if the query analyzer
    * is case insensitive. We should change attribute names to match the ones in the schema,
    * so we do not need to worry about case sensitivity anymore.
    */
-  protected[sql] def normalizeExprs(

Review comment:
       not sure if this is needed given `HiveStrategies.scala` is also within the `sql` scope?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org