You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Kyle Weaver (Jira)" <ji...@apache.org> on 2020/05/13 00:32:00 UTC
[jira] [Commented] (BEAM-9935) Resolve differences in
allowed_split_point implementations
[ https://issues.apache.org/jira/browse/BEAM-9935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17105842#comment-17105842 ]
Kyle Weaver commented on BEAM-9935:
-----------------------------------
https://github.com/apache/beam/pull/11671 solved this for Python, which is all we needed in 2.21 IIUC. Moving fix version to 2.22 for Java and Go.
> Resolve differences in allowed_split_point implementations
> ----------------------------------------------------------
>
> Key: BEAM-9935
> URL: https://issues.apache.org/jira/browse/BEAM-9935
> Project: Beam
> Issue Type: Bug
> Components: sdk-go, sdk-java-harness, sdk-py-harness
> Reporter: Luke Cwik
> Assignee: Robert Bradshaw
> Priority: Blocker
> Fix For: 2.21.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> [Java SDK harness|https://github.com/apache/beam/blob/d82d061aa303430f3d2853f397f3130fae6200cd/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/BeamFnDataReadRunner.java#L223] doesn't support it yet which is also safe.
> [Go SDK harness|https://github.com/apache/beam/blob/d82d061aa303430f3d2853f397f3130fae6200cd/sdks/go/pkg/beam/core/runtime/exec/datasource.go#L273] only supports splits if points are specified and it doesn't use the fraction at all.
> [Python SDK harness|https://github.com/apache/beam/blob/d82d061aa303430f3d2853f397f3130fae6200cd/sdks/python/apache_beam/runners/worker/bundle_processor.py#L947] ignores the split points meaning that it may return an invalid split location based upon the runners limitations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)