You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/10/05 21:29:56 UTC

[GitHub] [pinot] amrishlal edited a comment on pull request #7442: ban prefix increment

amrishlal edited a comment on pull request #7442:
URL: https://github.com/apache/pinot/pull/7442#issuecomment-934872313


   @richardstartin Pre and Post increment are fundamentally different in terms of their semantics and the difference in performance comes from the fact that post increment makes a copy while as pre-increment does not. A simple search would bring up many articles on this, but I am not seeing anything at all regarding banning pre/postincrement operator within loops.
   
   The loops that you wrote are extremely simple, to the point where the semantic difference between pre and post increment operators doesn't matter. Hence, the same underlying compiled code. However, that still doesn't lead to the conclusion that preincrement should be banned. We shouldn't be banning operators that are fundamental to a language.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org