[jira] [Resolved] (AMQ-5859) Reconnection attempt logic seems wrong in JmsConnector#doInitializeConnection

["Timothy Bish (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AMQ-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish resolved AMQ-5859.
-------------------------------
       Resolution: Fixed
    Fix Version/s: 5.12.0

Added a fix based on the original patch that keeps the original idea of infinite retries if the max is set to -1 and also fixed an NPE case seen in the tests.  

> Reconnection attempt logic seems wrong in JmsConnector#doInitializeConnection
> -----------------------------------------------------------------------------
>
>                 Key: AMQ-5859
>                 URL: https://issues.apache.org/jira/browse/AMQ-5859
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.10.2, 5.11.1
>            Reporter: Benoit Wiart
>            Priority: Critical
>             Fix For: 5.12.0
>
>         Attachments: 0001-AMQ-5859-Reconnection-attempt-logic-seems-wrong-in-J.patch
>
>
> the reconnection attempts logic  based on the reconnection policy seems wrong.
> In JmsConnector#doInitializeConnection the loop trying to reconnect to the foreign broker only execute once due to the erroneous test in the while
> {code}
> while (maxRetries < ++attempt && !connectionSerivce.isTerminating());
> {code}
> should be
> {code}
> while (maxRetries > ++attempt && !connectionSerivce.isTerminating());
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)