You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mittalsuraj18 (via GitHub)" <gi...@apache.org> on 2023/02/22 08:46:42 UTC

[GitHub] [superset] mittalsuraj18 opened a new pull request, #23153: Add indian numbering system

mittalsuraj18 opened a new pull request, #23153:
URL: https://github.com/apache/superset/pull/23153

   feat(numbering_system): add Indian Numbering System
   
   ### SUMMARY
   This PR adds indian numbering system to the superset UI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] Add indian numbering system [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #23153: Add indian numbering system
URL: https://github.com/apache/superset/pull/23153


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] Add indian numbering system [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23153:
URL: https://github.com/apache/superset/pull/23153#issuecomment-1936540925

   Closing/reopening to see if CI passes. Thanks for the contribution... I remember posting this on stack overflow (or you came to a similar solution!) but I'm not sure if we want to merge this or not as a default option, now that we have more places to add/customize/configure these formatters. Assigning to @kgabryje since he knows the lay of the land here and might have the best advice on if/how to proceed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] Add indian numbering system [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23153:
URL: https://github.com/apache/superset/pull/23153#issuecomment-2741794721

   This has sat untouched in draft mode for quite a while, so we'll go ahead and close it. We welcome you to reopen it if you want to contribute the change. Thank you for your contribution nonetheless! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org