You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by rvs <gi...@git.apache.org> on 2017/04/20 18:34:14 UTC
[GitHub] incubator-madlib pull request #123: MADLIB-1076. Review LICENSE file and REA...
GitHub user rvs opened a pull request:
https://github.com/apache/incubator-madlib/pull/123
MADLIB-1076. Review LICENSE file and README.md
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rvs/incubator-madlib master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-madlib/pull/123.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #123
----
commit 0d27956ba0e3bda71c6b8ef7da2ddc6a75b5db00
Author: Roman Shaposhnik <rv...@apache.org>
Date: 2017-04-20T18:02:43Z
MADLIB-1076. Review LICENSE file and README.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #123: MADLIB-1076. Review LICENSE file and REA...
Posted by iyerr3 <gi...@git.apache.org>.
Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/123#discussion_r112544856
--- Diff: licenses/MADlib.txt ---
@@ -1,10 +0,0 @@
-Portions of this software Copyright (c) 2010-2013 by EMC Corporation. All rights reserved.
--- End diff --
Is this file necessary?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #123: MADLIB-1076. Review LICENSE file and REA...
Posted by rvs <gi...@git.apache.org>.
Github user rvs commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/123#discussion_r112552157
--- Diff: src/CMakeLists.txt ---
@@ -18,10 +18,10 @@ set(BITBUCKET_BASE_URL
"${MADLIB_REDIRECT_PREFIX}https://bitbucket.org"
CACHE STRING
"Base URL for Bitbucket projects. May be overridden for testing purposes.")
-set(GITHUB_MADLIB_BASE_URL
+set(EIGEN_BASE_URL
--- End diff --
Will do. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #123: MADLIB-1076. Review LICENSE file and REA...
Posted by rvs <gi...@git.apache.org>.
Github user rvs commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/123#discussion_r112551993
--- Diff: licenses/MADlib.txt ---
@@ -1,10 +0,0 @@
-Portions of this software Copyright (c) 2010-2013 by EMC Corporation. All rights reserved.
--- End diff --
This file is actually being replaced with a symlink to ../LICENSE -- it seems to be necessary for Mac OS X packaging. I can also replace it with a copy of LICENSE, but that'll be a tad messy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib issue #123: MADLIB-1076. Review LICENSE file and README.md
Posted by fmcquillan99 <gi...@git.apache.org>.
Github user fmcquillan99 commented on the issue:
https://github.com/apache/incubator-madlib/pull/123
Looks good, thanks for the PR.
One double check: the LICENSE file you are proposing refers explicitly to libstemmer, useLatex and pyyaml, but does not call out other 3rd party components by name. Is that your intention?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #123: MADLIB-1076. Review LICENSE file and REA...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-madlib/pull/123
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #123: MADLIB-1076. Review LICENSE file and REA...
Posted by iyerr3 <gi...@git.apache.org>.
Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/123#discussion_r112544703
--- Diff: src/CMakeLists.txt ---
@@ -18,10 +18,10 @@ set(BITBUCKET_BASE_URL
"${MADLIB_REDIRECT_PREFIX}https://bitbucket.org"
CACHE STRING
"Base URL for Bitbucket projects. May be overridden for testing purposes.")
-set(GITHUB_MADLIB_BASE_URL
+set(EIGEN_BASE_URL
--- End diff --
Since this is Eigen specific link, please include the `eigen/archive` part from line 55 in the URL itself. That way it's used specifically for that purpose.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib issue #123: MADLIB-1076. Review LICENSE file and README.md
Posted by iyerr3 <gi...@git.apache.org>.
Github user iyerr3 commented on the issue:
https://github.com/apache/incubator-madlib/pull/123
Jenkins, OK to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib issue #123: MADLIB-1076. Review LICENSE file and README.md
Posted by fmcquillan99 <gi...@git.apache.org>.
Github user fmcquillan99 commented on the issue:
https://github.com/apache/incubator-madlib/pull/123
In file ReadMe_Build.txt the lines 38-40 should be updated from
+ PostgreSQL 9.2, 9.3, 9.4
+ HAWQ 1.2, 1.3
+ Greenplum 4.2, 4.3
to
+ PostgreSQL 9.5, 9.6
+ HAWQ 2.x
+ Greenplum 4.3.x, 5.x
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #123: MADLIB-1076. Review LICENSE file and REA...
Posted by iyerr3 <gi...@git.apache.org>.
Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/123#discussion_r112568270
--- Diff: licenses/MADlib.txt ---
@@ -1,10 +0,0 @@
-Portions of this software Copyright (c) 2010-2013 by EMC Corporation. All rights reserved.
--- End diff --
Thanks, Roman.
Symlink would be the best option if we have to keep the file.
Alternatively, we can change the `"${CMAKE_SOURCE_DIR}/licenses/MADlib.txt"` in `deploy/PackageMaker/CMakeLists.txt` to `"${CMAKE_SOURCE_DIR}/LICENSE"` and remove this file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---