You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "Michael Vorburger (Jira)" <ji...@apache.org> on 2020/08/26 01:16:00 UTC
[jira] [Commented] (FINERACT-821) Enable and enforce (!) Checkstyle
in Fineract
[ https://issues.apache.org/jira/browse/FINERACT-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184832#comment-17184832 ]
Michael Vorburger commented on FINERACT-821:
--------------------------------------------
[~aleks] similar to FINERACT-733, let's close this for 1.4.0 instead of keeping it open for 1.5.0; MUCH work happened here, and this should show up on 1.4.0 Release Notes.
[~Manthan] if you had planned any more more re. this, please create separate new JIRA issues, and link them as Related to this one.
> Enable and enforce (!) Checkstyle in Fineract
> ---------------------------------------------
>
> Key: FINERACT-821
> URL: https://issues.apache.org/jira/browse/FINERACT-821
> Project: Apache Fineract
> Issue Type: Improvement
> Reporter: Michael Vorburger
> Assignee: Manthan Surkar
> Priority: Major
> Fix For: 1.5.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> as suggested in FINERACT-712, we really should enable Checkstyle in Fineract.
> My past experience in such matters, confirmed by FINERACT-702, is that these things only ever work and have a lasting effect if you bulk fix all violations and switch on enforcement. If you only report, it's mostly useless.
> As for specific Checkstyle rules, I have spent a fair amount of time in a past life on a project (which I'm currently no longer actively invoved in) to refine a what I believe to be "good" Checkstyle rule set, we could reuse this for Fineract (it's EPL licensed, so copy/pasting it is perfectly fine), see https://github.com/opendaylight/odlparent/blob/master/checkstyle/src/main/resources/odl_checks.xml
--
This message was sent by Atlassian Jira
(v8.3.4#803005)