You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/08/05 00:02:37 UTC

[GitHub] [helix] jiajunwang commented on a change in pull request #1201: Identify and shutdown leaked timer threads

jiajunwang commented on a change in pull request #1201:
URL: https://github.com/apache/helix/pull/1201#discussion_r465395841



##########
File path: helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -1272,7 +1280,7 @@ protected void checkLiveInstancesObservation(List<LiveInstance> liveInstances,
 
   public void shutdown() throws InterruptedException {
     stopPeriodRebalance();
-
+    stopOnDemandTimer();

Review comment:
       Shall we also stopOnDemandTimer on the FINALIZE notification? This is done for the PeriodRebalance timer.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org