Proxy transformer and namespaces (was: svn commit: r594615 - in /lenya/trunk/src: java/org/apache/lenya/cms/cocoon/components/modules/input/ modules-core/linking/config/sitemap/ modules/bxe/ webapp/lenya/xslt/resources/)

[Andreas Hartmann <an...@apache.org>]

Hi Jörn,

[...]

> Modified: lenya/trunk/src/modules-core/linking/config/sitemap/transformers.xmap
> URL: http://svn.apache.org/viewvc/lenya/trunk/src/modules-core/linking/config/sitemap/transformers.xmap?rev=594615&r1=594614&r2=594615&view=diff
> ==============================================================================
> --- lenya/trunk/src/modules-core/linking/config/sitemap/transformers.xmap (original)
> +++ lenya/trunk/src/modules-core/linking/config/sitemap/transformers.xmap Tue Nov 13 11:36:51 2007
> @@ -47,7 +47,9 @@
>      <transform namespace="http://www.w3.org/1999/xhtml" element="img" attribute="src"/>
>      <transform namespace="http://www.w3.org/1999/xhtml" element="link" attribute="href"/>
>      <transform namespace="http://www.w3.org/1999/xhtml" element="form" attribute="action"/>
> -    <transform namespace="http://www.w3.org/1999/xhtml" element="script" attribute="src"/>
> +    <transform namespace="http://www.w3.org/1999/xhtml" element="script" attribute="src"/>
> +<!-- temporary fix for bxe. should be reconsidered -->
> +    <transform namespace="http://relaxng.org/ns/structure/1.0" element="include" attribute="href"/>
>    </map:transformer>

I declared a dedicated transformer for this (revision 595270).

IMO we shouldn't use one proxy transformer for all namespaces. I guess 
we should even rename the "proxy" transformer to "proxy-xhtml". WDYT?

-- Andreas


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org

Re: Proxy transformer and namespaces

[Jörn Nettingsmeier <ne...@apache.org>]

Andreas Hartmann wrote:
> Hi Jörn,
> 
> 
> I declared a dedicated transformer for this (revision 595270).

yeah, as i said, that's much cleaner than my patch.

> IMO we shouldn't use one proxy transformer for all namespaces. I guess 
> we should even rename the "proxy" transformer to "proxy-xhtml". WDYT?

i'd say no renames before 2.0. after that, +1.
*BUT*: we should be very careful about adding more proxy-dependent links 
to other types of documents - each one is a bug waiting to happen and an 
extra transform.
i think this stuff should be handled by special pipelines *in the 
module*, not the generic module-resources ones. "resources" as we used 
it implied "static resources" which implied <map:read/>. it needs to be 
obvious that we are serving dynamic stuff with setup-dependant 
transforms in them.
if the xhtml module thinks it has to be clever wrt rng includes, let it 
handle the mess itself. making global provisions for this means 
encouraging the use of includes, which is a double-edged sword, 
especially since there are certainly rng engines out there that do not 
resolve them. i'd say let's handle resolve the includes on the server 
and pass just one monolithic rng to the client. it's bound to be faster 
as well, less http overhead, and is very cacheable.


-- 
Jörn Nettingsmeier

"One of my most productive days was throwing away 1000 lines of code."
   - Ken Thompson.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org