You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by jackylk <gi...@git.apache.org> on 2017/12/07 11:44:19 UTC
[GitHub] carbondata pull request #1631: [CARBONDATA-1872][API] Remove unused carbon p...
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/1631
[CARBONDATA-1872][API] Remove unused carbon property
Remove unused constant string in CarbonCommonConstant
- [X] Any interfaces changed?
NO
- [X] Any backward compatibility impacted?
NO
- [X] Document update required?
No
- [X] Testing done
No logic is modified, it can be tested by existing testsuite
- [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jackylk/incubator-carbondata remove_useless_carbon_property
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1631.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1631
----
commit 1d83427a99c5182c68672d86af24fa2f0299ebde
Author: Jacky Li <ja...@qq.com>
Date: 2017-12-07T11:40:45Z
remove unused carbon property
----
---
[GitHub] carbondata issue #1631: [CARBONDATA-1872][API] Clean up unused constant in C...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1631
retest this please
---
[GitHub] carbondata issue #1631: [CARBONDATA-1872][API] Clean up unused constant in C...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1631
LGTM
---
[GitHub] carbondata issue #1631: [CARBONDATA-1872][API] Clean up unused constant in C...
Posted by QiangCai <gi...@git.apache.org>.
Github user QiangCai commented on the issue:
https://github.com/apache/carbondata/pull/1631
retest this please
---
[GitHub] carbondata issue #1631: [CARBONDATA-1872][API] Clean up unused constant in C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1631
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/628/
---
[GitHub] carbondata issue #1631: [CARBONDATA-1872][API] Clean up unused constant in C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1631
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/888/
---
[GitHub] carbondata issue #1631: [CARBONDATA-1872][API] Clean up unused constant in C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1631
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2113/
---
[GitHub] carbondata issue #1631: [CARBONDATA-1872][API] Clean up unused constant in C...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1631
@jackylk I have reverted this commit as SDV tests are compilation failed because of some constants removed. Please fix it. I merge again.
---
[GitHub] carbondata issue #1631: [CARBONDATA-1872][API] Clean up unused constant in C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1631
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1856/
---
[GitHub] carbondata issue #1631: [CARBONDATA-1872][API] Clean up unused constant in C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1631
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/574/
---
[GitHub] carbondata pull request #1631: [CARBONDATA-1872][API] Clean up unused consta...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1631
---