You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Thejas Nair <th...@hortonworks.com> on 2014/08/28 00:30:11 UTC
Review Request 25125: HIVE-7895 : Storage based authorization should
consider sticky bit for drop actions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25125/
-----------------------------------------------------------
Review request for hive, Jason Dere and Sushanth Sowmyan.
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-7895
Diffs
-----
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestStorageBasedMetastoreAuthorizationDrops.java PRE-CREATION
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestStorageBasedMetastoreAuthorizationProvider.java b447204
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/StorageBasedAuthorizationProvider.java ddbe30c
Diff: https://reviews.apache.org/r/25125/diff/
Testing
-------
New tests included.
Thanks,
Thejas Nair
Re: Review Request 25125: HIVE-7895 : Storage based authorization
should consider sticky bit for drop actions
Posted by Thejas Nair <th...@hortonworks.com>.
> On Aug. 28, 2014, 5:13 a.m., Jason Dere wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/StorageBasedAuthorizationProvider.java, line 191
> > <https://reviews.apache.org/r/25125/diff/1/?file=670613#file670613line191>
> >
> > Is it necessary to check the delete privs on the parent dir for external tables, given that the table directory is not actually deleted for external tables?
Thanks for pointing this out! I forgot about the external table use case!
- Thejas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25125/#review51727
-----------------------------------------------------------
On Aug. 27, 2014, 10:30 p.m., Thejas Nair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25125/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2014, 10:30 p.m.)
>
>
> Review request for hive, Jason Dere and Sushanth Sowmyan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-7895
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestStorageBasedMetastoreAuthorizationDrops.java PRE-CREATION
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestStorageBasedMetastoreAuthorizationProvider.java b447204
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/StorageBasedAuthorizationProvider.java ddbe30c
>
> Diff: https://reviews.apache.org/r/25125/diff/
>
>
> Testing
> -------
>
> New tests included.
>
>
> Thanks,
>
> Thejas Nair
>
>
Re: Review Request 25125: HIVE-7895 : Storage based authorization
should consider sticky bit for drop actions
Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25125/#review51727
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/StorageBasedAuthorizationProvider.java
<https://reviews.apache.org/r/25125/#comment90299>
Is it necessary to check the delete privs on the parent dir for external tables, given that the table directory is not actually deleted for external tables?
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/StorageBasedAuthorizationProvider.java
<https://reviews.apache.org/r/25125/#comment90283>
Consider moving some of this functionality to FileUtils as a utility function. I can think of a couple of places that could use this, HMSHandler.drop_database_core() and SessionHiveMetaStoreClient.dropTempTable() both call Warehouse.isWritable(), but this functionality in this method may be more appropriate.
- Jason Dere
On Aug. 27, 2014, 10:30 p.m., Thejas Nair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25125/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2014, 10:30 p.m.)
>
>
> Review request for hive, Jason Dere and Sushanth Sowmyan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-7895
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestStorageBasedMetastoreAuthorizationDrops.java PRE-CREATION
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestStorageBasedMetastoreAuthorizationProvider.java b447204
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/StorageBasedAuthorizationProvider.java ddbe30c
>
> Diff: https://reviews.apache.org/r/25125/diff/
>
>
> Testing
> -------
>
> New tests included.
>
>
> Thanks,
>
> Thejas Nair
>
>
Re: Review Request 25125: HIVE-7895 : Storage based authorization
should consider sticky bit for drop actions
Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25125/#review51862
-----------------------------------------------------------
Ship it!
Ship It!
- Jason Dere
On Aug. 28, 2014, 8:16 p.m., Thejas Nair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25125/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2014, 8:16 p.m.)
>
>
> Review request for hive, Jason Dere and Sushanth Sowmyan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-7895
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/FileUtils.java f71bc3c
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestStorageBasedMetastoreAuthorizationDrops.java PRE-CREATION
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestStorageBasedMetastoreAuthorizationProvider.java b447204
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/StorageBasedAuthorizationProvider.java ddbe30c
>
> Diff: https://reviews.apache.org/r/25125/diff/
>
>
> Testing
> -------
>
> New tests included.
>
>
> Thanks,
>
> Thejas Nair
>
>
Re: Review Request 25125: HIVE-7895 : Storage based authorization
should consider sticky bit for drop actions
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25125/
-----------------------------------------------------------
(Updated Aug. 28, 2014, 8:16 p.m.)
Review request for hive, Jason Dere and Sushanth Sowmyan.
Changes
-------
addressing review comments
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-7895
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/FileUtils.java f71bc3c
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestStorageBasedMetastoreAuthorizationDrops.java PRE-CREATION
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestStorageBasedMetastoreAuthorizationProvider.java b447204
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/StorageBasedAuthorizationProvider.java ddbe30c
Diff: https://reviews.apache.org/r/25125/diff/
Testing
-------
New tests included.
Thanks,
Thejas Nair