[jira] [Commented] (CLOUDSTACK-10042) UI doesn't show ICMP Type and Code for Security Group rules

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120794#comment-16120794 ] 

ASF subversion and git services commented on CLOUDSTACK-10042:
--------------------------------------------------------------

Commit 86b6050c322aeb881d68e2235ee91fecbd1d974b in cloudstack's branch refs/heads/4.9 from [~widodh]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=86b6050 ]

CLOUDSTACK-10042: Properly show ICMP SecGroup Rules (#2233)

A simple if-statement would fail if either the type or code were 0
as that if-statement failed them.

By checking if they are defined and casting them to a String afterwards
this makes the if-statement properly resolve and show the rule as it should.

Signed-off-by: Wido den Hollander <wi...@widodh.nl>

> UI doesn't show ICMP Type and Code for Security Group rules
> -----------------------------------------------------------
>
>                 Key: CLOUDSTACK-10042
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10042
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: UI
>    Affects Versions: 4.9.0, 4.10.0.0
>            Reporter: Wido den Hollander
>             Fix For: 4.10.1.0, 4.9.3.0
>
>
> A simple if-statement in network.js fails because icmptype and code are a Integer which results in a False for the If-Statement.
> This causes the UI to bork on displaying that rule properly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)