You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tiles.apache.org by "David H. DeWolf" <dd...@apache.org> on 2007/02/09 13:48:52 UTC
[VOTE] 2.0.0 Release Quality
The Tiles 2.0.0 test build has been available since February 6, 2007.
Release notes:
*
https://issues.apache.org/struts/secure/ReleaseNote.jspa?version=21781&styleName=Html&projectId=10160&Create=Create
Distribution:
* http://people.apache.org/builds/tiles/
Maven 2 staging repository:
* http://people.apache.org/builds/tiles/m2-staging-repository/
If you have had a chance to review the test build, please respond with a
vote on its quality:
[ ] Leave at test build
[ ] Alpha
[ ] Beta
[ ] General Availability (GA)
Everyone who has tested the build is invited to vote. Votes by PMC
members are considered binding. A vote passes if there are at least
three binding +1s and more +1s than -1s.
Please remember that a binding +1 for GA implies that you intend to
support the release by applying patches and responding to posts to the
user and dev lists.
Re: [VOTE] 2.0.0 Release Quality
Posted by Nathan Bubna <nb...@gmail.com>.
On 2/9/07, David H. DeWolf <dd...@apache.org> wrote:
> The Tiles 2.0.0 test build has been available since February 6, 2007.
>
> Release notes:
>
> *
> https://issues.apache.org/struts/secure/ReleaseNote.jspa?version=21781&styleName=Html&projectId=10160&Create=Create
>
>
> Distribution:
>
> * http://people.apache.org/builds/tiles/
>
> Maven 2 staging repository:
>
> * http://people.apache.org/builds/tiles/m2-staging-repository/
>
> If you have had a chance to review the test build, please respond with a
> vote on its quality:
>
> [X] Leave at test build
> [ ] Alpha
> [ ] Beta
> [ ] General Availability (GA)
Sorry, as loose as my standards for alpha's are regarding stability,
code-completeness, and code-quality, i feel any ASF release ought to
have a proper source distribution.
> Everyone who has tested the build is invited to vote. Votes by PMC
> members are considered binding. A vote passes if there are at least
> three binding +1s and more +1s than -1s.
>
> Please remember that a binding +1 for GA implies that you intend to
> support the release by applying patches and responding to posts to the
> user and dev lists.
>
>
Re: [VOTE] 2.0.0 Release Quality
Posted by "David H. DeWolf" <dd...@apache.org>.
I just realized tat I copied this email straight from the Struts wiki
and only replaced the urls/names. I'm sure that we don't agree with the
last paragraph, so I've removed it from the template for this email
posted on the wiki.
David H. DeWolf wrote:
> The Tiles 2.0.0 test build has been available since February 6, 2007.
>
> Release notes:
>
> *
> https://issues.apache.org/struts/secure/ReleaseNote.jspa?version=21781&styleName=Html&projectId=10160&Create=Create
>
>
> Distribution:
>
> * http://people.apache.org/builds/tiles/
>
> Maven 2 staging repository:
>
> * http://people.apache.org/builds/tiles/m2-staging-repository/
>
> If you have had a chance to review the test build, please respond with a
> vote on its quality:
>
> [ ] Leave at test build
> [ ] Alpha
> [ ] Beta
> [ ] General Availability (GA)
>
> Everyone who has tested the build is invited to vote. Votes by PMC
> members are considered binding. A vote passes if there are at least
> three binding +1s and more +1s than -1s.
>
> Please remember that a binding +1 for GA implies that you intend to
> support the release by applying patches and responding to posts to the
> user and dev lists.
>
>
Re: [VOTE] 2.0.0 Release Quality
Posted by "David H. DeWolf" <dd...@apache.org>.
David H. DeWolf wrote:
>
> [ ] Leave at test build
> [X] Alpha
> [ ] Beta
> [ ] General Availability (GA)
>
Re: [VOTE] 2.0.0 Release Quality
Posted by "David H. DeWolf" <dd...@apache.org>.
Awesome! Thanks a ton.
David
Niall Pemberton wrote:
> On 2/9/07, Niall Pemberton <ni...@gmail.com> wrote:
>> On 2/9/07, David H. DeWolf <dd...@apache.org> wrote:
>> >
>> > [X] Leave at test build
>> > [ ] Alpha
>> > [ ] Beta
>> > [ ] General Availability (GA)
>>
>> Apologies, meant to review earlier. I have a number of comments:
>>
>> - there is no source distro
>> - the binary distro doesn't contain the javadocs
>> - The sources jars are a mess containing duplicate copies of the java
>> files as well as the "target" directory with the binary jars, classes
>> files and surefire reports etc
>> - the manifest files don't contain the usual entries, I'd have
>> expected something like:
>> Extension-Name: Apache Tiles Core
>> Specification-Title: Apache Tiles Core
>> Specification-Version: 2.0.0
>> Specification-Vendor: The Apache Software Foundation
>> Implementation-Title: Apache Tiles Core
>> Implementation-Version: 2.0.0
>> Implementation-Vendor: The Apache Software Foundation
>> Implementation-Vendor-Id: org.apache
>> - DefinitionManager in core (org.apache.tiles.impl.mgmt) is missing a
>> source file header
>> - The notice file copyright statement is to 2006 (not 2007)
>
> I've posted a patch for all of the above (except sorting out the sources
> jar)
>
> https://issues.apache.org/struts/browse/TILES-109
>
> Need to run mvn site assembly:assembly (site creates Javadocs first)
>
> Not sure how to sort out the sources jars - suspect its because of one
> of your resources (for NOTICE and LICENSE) has
> <directory>.</directory> - maybe moving NOTICE and LICENSE to
> src/main/resources would be better and avoid this. Specifying the root
> directory in resource causes the plugin that creates the sources jar
> all sorts of problems - think its an outstanding bug, so best avoided.
>
> Niall
>
>
> Niall
>
>
>> Niall
>>
>
Re: [VOTE] 2.0.0 Release Quality
Posted by Niall Pemberton <ni...@gmail.com>.
On 2/9/07, Niall Pemberton <ni...@gmail.com> wrote:
> On 2/9/07, David H. DeWolf <dd...@apache.org> wrote:
> >
> > [X] Leave at test build
> > [ ] Alpha
> > [ ] Beta
> > [ ] General Availability (GA)
>
> Apologies, meant to review earlier. I have a number of comments:
>
> - there is no source distro
> - the binary distro doesn't contain the javadocs
> - The sources jars are a mess containing duplicate copies of the java
> files as well as the "target" directory with the binary jars, classes
> files and surefire reports etc
> - the manifest files don't contain the usual entries, I'd have
> expected something like:
> Extension-Name: Apache Tiles Core
> Specification-Title: Apache Tiles Core
> Specification-Version: 2.0.0
> Specification-Vendor: The Apache Software Foundation
> Implementation-Title: Apache Tiles Core
> Implementation-Version: 2.0.0
> Implementation-Vendor: The Apache Software Foundation
> Implementation-Vendor-Id: org.apache
> - DefinitionManager in core (org.apache.tiles.impl.mgmt) is missing a
> source file header
> - The notice file copyright statement is to 2006 (not 2007)
I've posted a patch for all of the above (except sorting out the sources jar)
https://issues.apache.org/struts/browse/TILES-109
Need to run mvn site assembly:assembly (site creates Javadocs first)
Not sure how to sort out the sources jars - suspect its because of one
of your resources (for NOTICE and LICENSE) has
<directory>.</directory> - maybe moving NOTICE and LICENSE to
src/main/resources would be better and avoid this. Specifying the root
directory in resource causes the plugin that creates the sources jar
all sorts of problems - think its an outstanding bug, so best avoided.
Niall
Niall
> Niall
>
Re: [VOTE] 2.0.0 Release Quality
Posted by "David H. DeWolf" <dd...@apache.org>.
Ok, good. We're on the same page then. I'll create an issue to add
this verbiage to our website so that it's clear.
Nathan Bubna wrote:
> On 2/9/07, David H. DeWolf <dd...@apache.org> wrote:
>>
>>
>> Nathan Bubna wrote:
>>
>> >
>> > For our purpose, yes. So far as i know, the only real requirements
>> > for a release are that we have our license ducks in a row and get
>> > three +1s for releasing from the PMC. I don't think there are any
>> > requirements on what label (test/alpha/beta/GA/M1/whatever) we give
>> > the build, however, for the purposes of establishing our release
>> > process, i do not think we should be releasing what we consider to be
>> > no better than test builds.
>>
>> Really? Than what would you suggest an alpha is? To me, alpha is
>> precisely that - a test build that has been pushed out to the public
>> in order to get additional feedback that will help in refining things
>> into a beta.
>
> They all start as a test build....
>
> A test build is a build that hopes to be released, but typically is
> not. This is what we vote on whether to release with either Alpha,
> Beta, or GA label or to keep as a mere test build and not release to
> the public. This should not be mirrored and not announced beyond the
> dev@ list, as it has not yet received PMC approval for release.
>
> An Alpha is a test build that we deem worthy of releasing with alpha
> label. For me, this merely means that it meets the standards for an
> ASF release, in terms of PMC approval, license stuff all properly in
> place, and includes both binary build and sources in the distribution.
> This can be announced to the user list and listed on the website, but
> the alpha label should be clear and a brief explanation/disclaimer
> isn't a bad idea.
>
> A Beta is a test build we deem worthy of releasing with the beta
> label. For me, this means that it meets the standards for an ASF
> release (same as above), but also is more stable and complete
> code-wise than an Alpha. Changes can be expected, but API changes
> should be minimal, usually just minor additions and bugfixes. This
> should definitely be announced to the user list and put on the
> website. Depending on the release manager's confidence in the quality
> and stability of this, they may even want to announce it more broadly.
>
> When we deem a test build worthy of releasing with the GA, this means
> we think the build is ready for use in production. We can announce it
> as far and wide as we like and voting +1 GA typically implies some
> degree of willingness to support the release on the user@ list.
>
>> If I'm off base, perhaps we're not ready for an initial release?
>
> Now that Niall's patches for the build process are in, i think we
> probably are.
>
>> David
>>
>> >
>> >> Thanks,
>> >> Greg
>> >>
>> >
>>
>
Re: [VOTE] 2.0.0 Release Quality
Posted by Nathan Bubna <nb...@gmail.com>.
On 2/9/07, David H. DeWolf <dd...@apache.org> wrote:
>
>
> Nathan Bubna wrote:
>
> >
> > For our purpose, yes. So far as i know, the only real requirements
> > for a release are that we have our license ducks in a row and get
> > three +1s for releasing from the PMC. I don't think there are any
> > requirements on what label (test/alpha/beta/GA/M1/whatever) we give
> > the build, however, for the purposes of establishing our release
> > process, i do not think we should be releasing what we consider to be
> > no better than test builds.
>
> Really? Than what would you suggest an alpha is? To me, alpha is
> precisely that - a test build that has been pushed out to the public
> in order to get additional feedback that will help in refining things
> into a beta.
They all start as a test build....
A test build is a build that hopes to be released, but typically is
not. This is what we vote on whether to release with either Alpha,
Beta, or GA label or to keep as a mere test build and not release to
the public. This should not be mirrored and not announced beyond the
dev@ list, as it has not yet received PMC approval for release.
An Alpha is a test build that we deem worthy of releasing with alpha
label. For me, this merely means that it meets the standards for an
ASF release, in terms of PMC approval, license stuff all properly in
place, and includes both binary build and sources in the distribution.
This can be announced to the user list and listed on the website, but
the alpha label should be clear and a brief explanation/disclaimer
isn't a bad idea.
A Beta is a test build we deem worthy of releasing with the beta
label. For me, this means that it meets the standards for an ASF
release (same as above), but also is more stable and complete
code-wise than an Alpha. Changes can be expected, but API changes
should be minimal, usually just minor additions and bugfixes. This
should definitely be announced to the user list and put on the
website. Depending on the release manager's confidence in the quality
and stability of this, they may even want to announce it more broadly.
When we deem a test build worthy of releasing with the GA, this means
we think the build is ready for use in production. We can announce it
as far and wide as we like and voting +1 GA typically implies some
degree of willingness to support the release on the user@ list.
> If I'm off base, perhaps we're not ready for an initial release?
Now that Niall's patches for the build process are in, i think we probably are.
> David
>
> >
> >> Thanks,
> >> Greg
> >>
> >
>
Re: [VOTE] 2.0.0 Release Quality
Posted by "David H. DeWolf" <dd...@apache.org>.
Nathan Bubna wrote:
>
> For our purpose, yes. So far as i know, the only real requirements
> for a release are that we have our license ducks in a row and get
> three +1s for releasing from the PMC. I don't think there are any
> requirements on what label (test/alpha/beta/GA/M1/whatever) we give
> the build, however, for the purposes of establishing our release
> process, i do not think we should be releasing what we consider to be
> no better than test builds.
Really? Than what would you suggest an alpha is? To me, alpha is
precisely that - a test build that has been pushed out to the public
in order to get additional feedback that will help in refining things
into a beta.
If I'm off base, perhaps we're not ready for an initial release?
David
>
>> Thanks,
>> Greg
>>
>
Re: [VOTE] 2.0.0 Release Quality
Posted by Nathan Bubna <nb...@gmail.com>.
On 2/9/07, Greg Reddin <gr...@gmail.com> wrote:
> On 2/9/07, Niall Pemberton <ni...@gmail.com> wrote:
> >
> > - DefinitionManager in core (org.apache.tiles.impl.mgmt) is missing a
> > source file header
> > - The notice file copyright statement is to 2006 (not 2007)
>
>
> [X] Leave at test build
> [ ] Alpha
> [ ] Beta
> [ ] General Availability (GA)
>
> Given the above 2 issues I have to agree with Niall. Thanks for such a
> thorough review :-). I think the other issues you listed would not prohibit
> an alpha. I guess the difference between a test build and an alpha is just
> that a test build is not an actual release?
For our purpose, yes. So far as i know, the only real requirements
for a release are that we have our license ducks in a row and get
three +1s for releasing from the PMC. I don't think there are any
requirements on what label (test/alpha/beta/GA/M1/whatever) we give
the build, however, for the purposes of establishing our release
process, i do not think we should be releasing what we consider to be
no better than test builds.
> Thanks,
> Greg
>
Re: [VOTE] 2.0.0 Release Quality
Posted by Greg Reddin <gr...@gmail.com>.
On 2/9/07, Niall Pemberton <ni...@gmail.com> wrote:
>
> - DefinitionManager in core (org.apache.tiles.impl.mgmt) is missing a
> source file header
> - The notice file copyright statement is to 2006 (not 2007)
[X] Leave at test build
[ ] Alpha
[ ] Beta
[ ] General Availability (GA)
Given the above 2 issues I have to agree with Niall. Thanks for such a
thorough review :-). I think the other issues you listed would not prohibit
an alpha. I guess the difference between a test build and an alpha is just
that a test build is not an actual release?
Thanks,
Greg
Re: [VOTE] 2.0.0 Release Quality
Posted by Niall Pemberton <ni...@gmail.com>.
Sorry, should have checked out Jira first for existing tickets :-(
I believe this is the issue with the sources jar plugin:
http://jira.codehaus.org/browse/MSOURCES-6
I'm fairly sure that if you move NOTICE.txt and LICENSE.txt out of the
"root" directory in each of your modules (suggest put it in
src/main/resources) and then change the resource <directory> element
in the pom's to the new location (instead of <directory>.</directory>)
then the problem goes away. If you add the assembly descriptors I
attached to the patch for TILES-109 then you'll need to correct the
location in there as well).
Niall
On 2/9/07, David H. DeWolf <dd...@apache.org> wrote:
>
>
> Niall Pemberton wrote:
> > On 2/9/07, David H. DeWolf <dd...@apache.org> wrote:
> >>
> >> [X] Leave at test build
> >> [ ] Alpha
> >> [ ] Beta
> >> [ ] General Availability (GA)
> >
> > Apologies, meant to review earlier. I have a number of comments:
>
> Better late than never :) Sometimes it takes a vote thread to kick start
> the process I guess!
>
> >
> > - there is no source distro
> > - the binary distro doesn't contain the javadocs
>
> TILES-105, TILES-106
>
> Do these need to be in place for an alpha? IMO we're simply trying to
> get binaries out. According to HTTPD docs, "Alpha indicates that the
> release is not meant for mainstream usage or may have serious problems
> that prohibits its use." Missing docs seem to fall in that category.
>
> > - The sources jars are a mess containing duplicate copies of the java
> > files as well as the "target" directory with the binary jars, classes
> > files and surefire reports etc
>
> TILES-107
>
> Hmmm. Is this a known problem with the maven-release-plugin? Anyone
> know how to change this?
>
> > - the manifest files don't contain the usual entries, I'd have
> > expected something like:
> > Extension-Name: Apache Tiles Core
> > Specification-Title: Apache Tiles Core
> > Specification-Version: 2.0.0
> > Specification-Vendor: The Apache Software Foundation
> > Implementation-Title: Apache Tiles Core
> > Implementation-Version: 2.0.0
> > Implementation-Vendor: The Apache Software Foundation
> > Implementation-Vendor-Id: org.apache
>
> TILES-108
>
> > - DefinitionManager in core (org.apache.tiles.impl.mgmt) is missing a
> > source file header
>
> Fixed in trunk
>
> > - The notice file copyright statement is to 2006 (not 2007)
>
> Fixed in trunk
>
> The latter two are probably enough to -1 any release. To this end, I've
> created jira issues for the above and will role 2.0.1 as soon as they
> are fixed. Unless, people want to retag and try a 2.0.0 again. I'm ok
> either way but would prefer the former.
>
> Thanks for reviewing!
>
> David
> >
> > Niall
> >
>
Re: [VOTE] 2.0.0 Release Quality
Posted by "David H. DeWolf" <dd...@apache.org>.
Niall Pemberton wrote:
> On 2/9/07, David H. DeWolf <dd...@apache.org> wrote:
>>
>> [X] Leave at test build
>> [ ] Alpha
>> [ ] Beta
>> [ ] General Availability (GA)
>
> Apologies, meant to review earlier. I have a number of comments:
Better late than never :) Sometimes it takes a vote thread to kick start
the process I guess!
>
> - there is no source distro
> - the binary distro doesn't contain the javadocs
TILES-105, TILES-106
Do these need to be in place for an alpha? IMO we're simply trying to
get binaries out. According to HTTPD docs, "Alpha indicates that the
release is not meant for mainstream usage or may have serious problems
that prohibits its use." Missing docs seem to fall in that category.
> - The sources jars are a mess containing duplicate copies of the java
> files as well as the "target" directory with the binary jars, classes
> files and surefire reports etc
TILES-107
Hmmm. Is this a known problem with the maven-release-plugin? Anyone
know how to change this?
> - the manifest files don't contain the usual entries, I'd have
> expected something like:
> Extension-Name: Apache Tiles Core
> Specification-Title: Apache Tiles Core
> Specification-Version: 2.0.0
> Specification-Vendor: The Apache Software Foundation
> Implementation-Title: Apache Tiles Core
> Implementation-Version: 2.0.0
> Implementation-Vendor: The Apache Software Foundation
> Implementation-Vendor-Id: org.apache
TILES-108
> - DefinitionManager in core (org.apache.tiles.impl.mgmt) is missing a
> source file header
Fixed in trunk
> - The notice file copyright statement is to 2006 (not 2007)
Fixed in trunk
The latter two are probably enough to -1 any release. To this end, I've
created jira issues for the above and will role 2.0.1 as soon as they
are fixed. Unless, people want to retag and try a 2.0.0 again. I'm ok
either way but would prefer the former.
Thanks for reviewing!
David
>
> Niall
>
Re: [VOTE] 2.0.0 Release Quality
Posted by Niall Pemberton <ni...@gmail.com>.
On 2/9/07, David H. DeWolf <dd...@apache.org> wrote:
>
> [X] Leave at test build
> [ ] Alpha
> [ ] Beta
> [ ] General Availability (GA)
Apologies, meant to review earlier. I have a number of comments:
- there is no source distro
- the binary distro doesn't contain the javadocs
- The sources jars are a mess containing duplicate copies of the java
files as well as the "target" directory with the binary jars, classes
files and surefire reports etc
- the manifest files don't contain the usual entries, I'd have
expected something like:
Extension-Name: Apache Tiles Core
Specification-Title: Apache Tiles Core
Specification-Version: 2.0.0
Specification-Vendor: The Apache Software Foundation
Implementation-Title: Apache Tiles Core
Implementation-Version: 2.0.0
Implementation-Vendor: The Apache Software Foundation
Implementation-Vendor-Id: org.apache
- DefinitionManager in core (org.apache.tiles.impl.mgmt) is missing a
source file header
- The notice file copyright statement is to 2006 (not 2007)
Niall
Re: [VOTE] 2.0.0 Release Quality
Posted by Antonio Petrelli <an...@gmail.com>.
> [ ] Leave at test build
> [X] Alpha
> [ ] Beta
> [ ] General Availability (GA)
Antonio