You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/04/03 20:45:30 UTC

[GitHub] [samza] Sanil15 commented on a change in pull request #1326: SAMZA-2492: Add new deserialize function for JobGraphJson and change the scope of related classes as public

Sanil15 commented on a change in pull request #1326: SAMZA-2492: Add new deserialize function for JobGraphJson and change the scope of related classes as public
URL: https://github.com/apache/samza/pull/1326#discussion_r403320866
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/execution/JobGraphJsonGenerator.java
 ##########
 @@ -44,9 +45,9 @@
 /**
  * This class generates the JSON representation of the {@link JobGraph}.
  */
-/* package private */ class JobGraphJsonGenerator {
+public class JobGraphJsonGenerator {
 
 Review comment:
   Since we are making them public, lets add some java docs for all the Pojo's and there use

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services