You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/06/30 09:30:58 UTC

[GitHub] [incubator-ratis] lokeshj1703 commented on a change in pull request #138: RATIS-989. Avoid change state from closing to exception in LogAppender

lokeshj1703 commented on a change in pull request #138:
URL: https://github.com/apache/incubator-ratis/pull/138#discussion_r447545765



##########
File path: ratis-server/src/main/java/org/apache/ratis/server/impl/LogAppender.java
##########
@@ -117,6 +121,16 @@ void stop() {
     public String toString() {
       return name;
     }
+
+    private boolean transLifeCycle(LifeCycle.State to) {

Review comment:
       NIT: Lets rename it to transitionLifeCycle.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org