[GitHub] KellenSunderland commented on issue #13322: Change CUB submodule to track Nvidia CUB project.

[GitBox <gi...@apache.org>]

KellenSunderland commented on issue #13322: Change CUB submodule to track Nvidia CUB project.
URL: https://github.com/apache/incubator-mxnet/pull/13322#issuecomment-441127263
 
 
   @frankfliu Thanks for the contribution.  Your description indicates why we're using the name '3rdparty/nvidia_cub' but not why we're switching submodules, which in my opinion is the more important piece of information.  Can you give some details around why we're switching back to the NVIDIA repo?
   
   If I remember correctly the reason we switched away from using the NVIDIA cub repo was because we had a bunch of force pushes and history re-writes in that repo that were causing us issues.  Looking at the current repo it seems like it's in really good shape now.  They describe their release process clearly and are making use of release branches.  Given they're using release branching, I'd suggest we track a specific stable branch using git 1.8 (and higher) submodule branch feature.  I hope this will help to protect us against future force-pushes.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services