You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sfirke (via GitHub)" <gi...@apache.org> on 2025/09/26 16:34:39 UTC
[I] Autocomplete matched text in SQL Lab is unreadable in dark theme (black on black) [superset]
sfirke opened a new issue, #35313:
URL: https://github.com/apache/superset/issues/35313
## Screenshot
Here I've typed "test" in my SQL Lab in dark theme. The letters of the matched objects are invisible b/c they're black text on black background:
<img width="913" height="207" alt="Image" src="https://github.com/user-attachments/assets/ea896afc-2587-48e7-ad36-e04e9e43bbcd" />
Here's the same thing on light theme:
<img width="871" height="172" alt="Image" src="https://github.com/user-attachments/assets/bad30483-6a25-4a4b-b914-81afdc196fb0" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Autocomplete matched text in SQL Lab is unreadable in dark theme (black on black) [superset]
Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on issue #35313:
URL: https://github.com/apache/superset/issues/35313#issuecomment-3339541488
<!-- Answer -->
This is a known issue caused by the autocomplete dropdown in SQL Lab using Ace Editor's static light theme, which doesn't adapt to Superset's dark mode. As a result, the matched text appears black on a black background in dark theme. The relevant styling is handled in the AceEditorWrapper and AsyncAceEditor components, but currently, there is no CSS override for the autocomplete text color in dark mode, nor does the Ace theme change dynamically with Superset's theme. This leads to the unreadable autocomplete text you’re seeing. Using theme tokens for text color, as done in other recent dark mode fixes, would resolve this issue, but it hasn't been implemented for the autocomplete dropdown yet. For reference, see the related discussion and code details [here](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx) and [here](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b
063ffe45377799c/superset-frontend/packages/superset-ui-core/src/components/AsyncAceEditor/index.tsx).
<!-- Dosu Comment Footer -->
*To reply, just mention [@dosu](https://go.dosu.dev/dosubot).*
---
<sup>How did I do? [Good](https://app.dosu.dev/response-feedback/35bb4de9-f95e-4e78-aa59-ca88d61c9a23?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/35bb4de9-f95e-4e78-aa59-ca88d61c9a23?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/35bb4de9-f95e-4e78-aa59-ca88d61c9a23?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/35bb4de9-f95e-4e78-aa59-ca88d61c9a23?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/35bb4de9-f95e-4e78-aa59-ca88d61c9a23?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/35bb4de9-f95e-4e78-aa59-ca88d61c9a23?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/35bb4de9-f95e-4e78-aa59-ca88d61c9a23?feedback_type=other)</sup> [](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=githu
b) [](https://go.dosu.dev/discord-bot) [](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/35313)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Autocomplete matched text in SQL Lab is unreadable in dark theme (black on black) [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido closed issue #35313: Autocomplete matched text in SQL Lab is unreadable in dark theme (black on black)
URL: https://github.com/apache/superset/issues/35313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org