[jira] Commented: (WOOKIE-65) Refactored comet notifications with sibling-instance scope

["Scott Wilson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WOOKIE-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806322#action_12806322 ] 

Scott Wilson commented on WOOKIE-65:
------------------------------------

Note that Felix's students did some similar modifications, and so it would be worth comparing the two sets of mods to see which is the better approach assuming they can submit their patch also.

> Refactored comet notifications with sibling-instance scope
> ----------------------------------------------------------
>
>                 Key: WOOKIE-65
>                 URL: https://issues.apache.org/jira/browse/WOOKIE-65
>             Project: Wookie
>          Issue Type: Improvement
>          Components: Server
>            Reporter: Scott Wilson
>         Attachments: notifications_patch.txt, notifications_patch_2.txt
>
>
> I've created an refactored version of the Notifier helper that is less "scattergun" in its approach to propagating notifications to widget instances, using the DWR PageNormalizer interface.
> This does get rid of some code duplication and generally makes the notifier easier to extend.
> However, I haven't been able to really test this and see how it affects performance - while it generates fewer pushes to clients, each client request potentially triggers more activity, so its possible this could go either way.
> With that in mind I've attached a patch for review rather than committing these changes as I'd appreciate feedback before going ahead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.