You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2018/08/14 15:28:55 UTC
[kudu-CR](gh-pages) [site] Add current Apache event
Hello Mike Percy, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11211
to review the following change.
Change subject: [site] Add current Apache event
......................................................................
[site] Add current Apache event
It's a best practice to add ApacheCon and other ASF-sponsored events to
the homepage.
According to the events README[1] there's an easy way to do it by
adding a link to https://www.apache.org/events/current-event.html
There's also an image that changes based on the current-event:
https://www.apache.org/events/current-event-234x60.png
[1] https://www.apache.org/events/README.txt
Change-Id: I945ad0432773d748bd21c21a7c55e5efca70b429
---
M index.html
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/11211/1
--
To view, visit http://gerrit.cloudera.org:8080/11211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newchange
Gerrit-Change-Id: I945ad0432773d748bd21c21a7c55e5efca70b429
Gerrit-Change-Number: 11211
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](gh-pages) [site] Add current Apache event
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11211 )
Change subject: [site] Add current Apache event
......................................................................
Patch Set 5:
yea, either bottom or top are preferable in my book but no strong feelings.
--
To view, visit http://gerrit.cloudera.org:8080/11211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I945ad0432773d748bd21c21a7c55e5efca70b429
Gerrit-Change-Number: 11211
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 16 Aug 2018 19:02:06 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [site] Add current Apache event
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11211 )
Change subject: [site] Add current Apache event
......................................................................
Patch Set 5:
Sounds good. I am okay with either approach.
--
To view, visit http://gerrit.cloudera.org:8080/11211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I945ad0432773d748bd21c21a7c55e5efca70b429
Gerrit-Change-Number: 11211
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 17 Aug 2018 14:34:27 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [site] Add current Apache event
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11211 )
Change subject: [site] Add current Apache event
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11211/4/index.html
File index.html:
http://gerrit.cloudera.org:8080/#/c/11211/4/index.html@21
PS4, Line 21: <a href="https://www.apache.org/events/current-event.html"><img src="https://www.apache.org/events/current-event-234x60.png"/></a>
> Yeah it's right there next to them. I wasn't sure where to put it, and it w
That's second one isn't bad. What about right aligned in the footer?
--
To view, visit http://gerrit.cloudera.org:8080/11211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I945ad0432773d748bd21c21a7c55e5efca70b429
Gerrit-Change-Number: 11211
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 16 Aug 2018 13:36:14 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] Add current Apache event
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11211 )
Change subject: [site] Add current Apache event
......................................................................
Patch Set 5:
> Patch Set 5:
>
> I don't have a strong preference. I think if you put it in the footer having it on every page is nice.
we can also show it on the top next to the Kudu logo on the rest of the pages though
--
To view, visit http://gerrit.cloudera.org:8080/11211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I945ad0432773d748bd21c21a7c55e5efca70b429
Gerrit-Change-Number: 11211
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 16 Aug 2018 22:31:51 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [site] Add current Apache event
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Anonymous Coward #425 has posted comments on this change. ( http://gerrit.cloudera.org:8080/11211 )
Change subject: [site] Add current Apache event
......................................................................
Patch Set 5:
> Patch Set 5:
>
> (1 comment)
Any of those 3 look fine to me - think top may be best.
--
To view, visit http://gerrit.cloudera.org:8080/11211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I945ad0432773d748bd21c21a7c55e5efca70b429
Gerrit-Change-Number: 11211
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Anonymous Coward #425
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 16 Aug 2018 16:24:54 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [site] Add current Apache event
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11211 )
Change subject: [site] Add current Apache event
......................................................................
Patch Set 5:
> Patch Set 5:
>
> yea, either bottom or top are preferable in my book but no strong feelings.
Grant, do you prefer top or bottom? Also, if we do top, should it still be there on non-index pages next to the Kudu logo or should the Kudu logo replace it?
--
To view, visit http://gerrit.cloudera.org:8080/11211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I945ad0432773d748bd21c21a7c55e5efca70b429
Gerrit-Change-Number: 11211
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 16 Aug 2018 20:35:25 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [site] Add current Apache event
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11211 )
Change subject: [site] Add current Apache event
......................................................................
[site] Add current Apache event
It's a best practice to add ApacheCon and other ASF-sponsored events to
the homepage.
According to the events README[1] there's an easy way to do it by
adding a link to https://www.apache.org/events/current-event.html
There's also an image that changes based on the current-event:
https://www.apache.org/events/current-event-234x60.png
[1] https://www.apache.org/events/README.txt
Change-Id: I945ad0432773d748bd21c21a7c55e5efca70b429
Reviewed-on: http://gerrit.cloudera.org:8080/11211
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
M _includes/bottom_common.html
1 file changed, 17 insertions(+), 8 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: merged
Gerrit-Change-Id: I945ad0432773d748bd21c21a7c55e5efca70b429
Gerrit-Change-Number: 11211
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](gh-pages) [site] Add current Apache event
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11211 )
Change subject: [site] Add current Apache event
......................................................................
Patch Set 6: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I945ad0432773d748bd21c21a7c55e5efca70b429
Gerrit-Change-Number: 11211
Gerrit-PatchSet: 6
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 17 Aug 2018 15:06:18 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [site] Add current Apache event
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11211 )
Change subject: [site] Add current Apache event
......................................................................
Patch Set 5:
I don't have a strong preference. I think if you put it in the footer having it on every page is nice.
--
To view, visit http://gerrit.cloudera.org:8080/11211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I945ad0432773d748bd21c21a7c55e5efca70b429
Gerrit-Change-Number: 11211
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 16 Aug 2018 21:10:18 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [site] Add current Apache event
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11211 )
Change subject: [site] Add current Apache event
......................................................................
Patch Set 6:
> Uploaded patch set 6.
Okay, it was kind of a tie (with no strong preferences from anyone), so I sent in a new patch with the it in the footer because that was already in my working directory (+ my wife liked that one best anyway)
--
To view, visit http://gerrit.cloudera.org:8080/11211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I945ad0432773d748bd21c21a7c55e5efca70b429
Gerrit-Change-Number: 11211
Gerrit-PatchSet: 6
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 17 Aug 2018 15:00:38 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [site] Add current Apache event
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11211 )
Change subject: [site] Add current Apache event
......................................................................
Patch Set 4:
(1 comment)
> Patch Set 4:
>
> (1 comment)
http://gerrit.cloudera.org:8080/#/c/11211/4/index.html
File index.html:
http://gerrit.cloudera.org:8080/#/c/11211/4/index.html@21
PS4, Line 21: <a href="https://www.apache.org/events/current-event.html"><img src="https://www.apache.org/events/current-event-234x60.png"/></a>
> mind posting a screenshot? It seems like this is going to be front-and-cent
Yeah it's right there next to them. I wasn't sure where to put it, and it was incidentally the same height as the buttons, so my colleague suggested to put it there. http://people.apache.org/~abukor/kudusite_apachecon.png
Any suggestions where to put it? I originally put it under the fast analytics column but it kinda felt weird there too.
My wife just suggested putting it at the top before the navbar, what do you think? http://people.apache.org/~abukor/kudusite_apachecon_top.png
--
To view, visit http://gerrit.cloudera.org:8080/11211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I945ad0432773d748bd21c21a7c55e5efca70b429
Gerrit-Change-Number: 11211
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 16 Aug 2018 06:08:23 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] Add current Apache event
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11211 )
Change subject: [site] Add current Apache event
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11211/4/index.html
File index.html:
http://gerrit.cloudera.org:8080/#/c/11211/4/index.html@21
PS4, Line 21: <a href="https://www.apache.org/events/current-event.html"><img src="https://www.apache.org/events/current-event-234x60.png"/></a>
> That's second one isn't bad. What about right aligned in the footer?
That also looks good. http://people.apache.org/~abukor/kudusite_apachecon_bottom.png
--
To view, visit http://gerrit.cloudera.org:8080/11211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I945ad0432773d748bd21c21a7c55e5efca70b429
Gerrit-Change-Number: 11211
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 16 Aug 2018 14:07:22 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] Add current Apache event
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Mitch Barnett, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11211
to look at the new patch set (#6).
Change subject: [site] Add current Apache event
......................................................................
[site] Add current Apache event
It's a best practice to add ApacheCon and other ASF-sponsored events to
the homepage.
According to the events README[1] there's an easy way to do it by
adding a link to https://www.apache.org/events/current-event.html
There's also an image that changes based on the current-event:
https://www.apache.org/events/current-event-234x60.png
[1] https://www.apache.org/events/README.txt
Change-Id: I945ad0432773d748bd21c21a7c55e5efca70b429
---
M _includes/bottom_common.html
1 file changed, 17 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/11211/6
--
To view, visit http://gerrit.cloudera.org:8080/11211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I945ad0432773d748bd21c21a7c55e5efca70b429
Gerrit-Change-Number: 11211
Gerrit-PatchSet: 6
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](gh-pages) [site] Add current Apache event
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11211 )
Change subject: [site] Add current Apache event
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11211/4/index.html
File index.html:
http://gerrit.cloudera.org:8080/#/c/11211/4/index.html@21
PS4, Line 21: <a href="https://www.apache.org/events/current-event.html"><img src="https://www.apache.org/events/current-event-234x60.png"/></a>
mind posting a screenshot? It seems like this is going to be front-and-center next to the "call to action" for install/download buttons which seems like a slightly odd placement.
--
To view, visit http://gerrit.cloudera.org:8080/11211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I945ad0432773d748bd21c21a7c55e5efca70b429
Gerrit-Change-Number: 11211
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 23:50:04 +0000
Gerrit-HasComments: Yes