You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org> on 2016/06/27 23:12:05 UTC
[kudu-CR] KUDU-1496. NoLeaderMasterFoundException are mishandled
Jean-Daniel Cryans has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3516
Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled
......................................................................
KUDU-1496. NoLeaderMasterFoundException are mishandled
This is a regression from 0c8f72b4c5d637dba4c0c0da4f55ea918c287d88.
Once we have multi-master unit tests re-enabled, we'll have this
covered.
Change-Id: Ie33410bdcfcc1bf9d3afb559a01f50538d7e10b5
---
M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
1 file changed, 6 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/3516/1
--
To view, visit http://gerrit.cloudera.org:8080/3516
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie33410bdcfcc1bf9d3afb559a01f50538d7e10b5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
[kudu-CR] KUDU-1496. NoLeaderMasterFoundException are mishandled
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled
......................................................................
Patch Set 1:
(1 comment)
> Oops.
>
> Outside of multi-master, this only manifests when the sole master
> is booting up, right? That would explain why it happens often in
> our unit tests.
Yup, I just didn't want to write tests that we already have.
http://gerrit.cloudera.org:8080/#/c/3516/1/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java:
Line 814: return d;
> is it important that the getDeferred call happen before delayedSendRpcToTab
If by some chance the RPC completed before the return is done, we'd be sending back a new Deferred. Almost impossible to run into, but hey...
--
To view, visit http://gerrit.cloudera.org:8080/3516
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie33410bdcfcc1bf9d3afb559a01f50538d7e10b5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Binglin Chang <de...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1496. NoLeaderMasterFoundException are mishandled
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled
......................................................................
Patch Set 1: Verified+1
Forcing +1 due to current messed up workspace.
--
To view, visit http://gerrit.cloudera.org:8080/3516
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie33410bdcfcc1bf9d3afb559a01f50538d7e10b5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Binglin Chang <de...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1496. NoLeaderMasterFoundException are mishandled
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled
......................................................................
KUDU-1496. NoLeaderMasterFoundException are mishandled
This is a regression from 0c8f72b4c5d637dba4c0c0da4f55ea918c287d88.
Once we have multi-master unit tests re-enabled, we'll have this
covered.
Change-Id: Ie33410bdcfcc1bf9d3afb559a01f50538d7e10b5
Reviewed-on: http://gerrit.cloudera.org:8080/3516
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Dan Burkert <da...@cloudera.com>
Tested-by: Jean-Daniel Cryans <jd...@apache.org>
---
M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
1 file changed, 6 insertions(+), 5 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Jean-Daniel Cryans: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/3516
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie33410bdcfcc1bf9d3afb559a01f50538d7e10b5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Binglin Chang <de...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
[kudu-CR] KUDU-1496. NoLeaderMasterFoundException are mishandled
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled
......................................................................
Patch Set 1: Code-Review+2
Oops.
Outside of multi-master, this only manifests when the sole master is booting up, right? That would explain why it happens often in our unit tests.
--
To view, visit http://gerrit.cloudera.org:8080/3516
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie33410bdcfcc1bf9d3afb559a01f50538d7e10b5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Binglin Chang <de...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] KUDU-1496. NoLeaderMasterFoundException are mishandled
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3516
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie33410bdcfcc1bf9d3afb559a01f50538d7e10b5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Binglin Chang <de...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] KUDU-1496. NoLeaderMasterFoundException are mishandled
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2061/
--
To view, visit http://gerrit.cloudera.org:8080/3516
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie33410bdcfcc1bf9d3afb559a01f50538d7e10b5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] KUDU-1496. NoLeaderMasterFoundException are mishandled
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3516/1/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java:
Line 814: return d;
is it important that the getDeferred call happen before delayedSendRpcToTablet? If not I would suggest directly returning request.getDeferred().
--
To view, visit http://gerrit.cloudera.org:8080/3516
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie33410bdcfcc1bf9d3afb559a01f50538d7e10b5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Binglin Chang <de...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes