You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by zellerh <gi...@git.apache.org> on 2016/04/19 22:28:46 UTC
[GitHub] incubator-trafodion pull request: TRAFODION-1940 better NATable st...
GitHub user zellerh opened a pull request:
https://github.com/apache/incubator-trafodion/pull/442
TRAFODION-1940 better NATable statistics plus OID, cleanhb fixes
TRAFODION-1939 Remove OID from the list of reserved words
TRAFODION-1940 Improve NATable statistics
- Add the context of the NATable cache
to the natablecache() UDF
- Add the entry size to the
natablecacheentries() UDF
Also changed the ilh_cleanhb script to print a help text
on how to use it and require a parameter 0, 1 or 2.
Still leaving the old, misspelled directory for zookeeper
in the script until everyone has moved to a later version
that puts the zookeeper data under local_hadoop/data/zookeeper.
Sorry for mixing three fixes into one PR.
TRAFODION-1939:
- ComResWords.cpp
- ParKeyWords.cpp
- EXPECTED037.SB
TRAFODION-1940:
- CmpContext.h
- NATableSt.cpp
- NATable.cpp
- NATable.h
- EXPECTED009
- TEST009
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zellerh/incubator-trafodion bug/1910
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/442.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #442
----
commit 985cecc4675c0d2df9de4a04f95e8a34c9fbbd16
Author: Hans Zeller <hz...@apache.org>
Date: 2016-04-19T20:20:03Z
TRAFODION-1940 better NATable statistics plus OID, cleanhb fixes
TRAFODION-1939 Remove OID from the list of reserved words
TRAFODION-1940 Improve NATable statistics
- Add the context of the NATable cache
to the natablecache() UDF
- Add the entry size to the
natablecacheentries() UDF
Also changed the ilh_cleanhb script to print a help text
on how to use it and require a parameter 0, 1 or 2.
Still leaving the old, misspelled directory for zookeeper
in the script until everyone has moved to a later version
that puts the zookeeper data under local_hadoop/data/zookeeper.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: TRAFODION-1940 better NATable st...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/442
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: TRAFODION-1940 better NATable st...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/442#discussion_r60328470
--- Diff: core/sql/regress/hive/TEST009 ---
@@ -170,7 +170,7 @@ sh sqlci -i "TEST009(select_stmts)";
select catalog_name, schema_name, object_name from table(natablecacheentries('user','local')) order by 1,2,3;
drop external table t009t1 for hive.sch_t009.t009t1;
get tables in schema "_HV_SCH_T009_";
-select * from table(natablecacheentries('user','local')) order by 2,3,4;
+select row_id, catalog_name, schema_name, object_name from table(natablecacheentries('user','local')) order by 2,3,4;
--- End diff --
Looks good. I'm wondering if it would be useful to add a test that also shows the new context column?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: TRAFODION-1940 better NATable st...
Posted by zellerh <gi...@git.apache.org>.
Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/442#discussion_r60328773
--- Diff: core/sql/regress/hive/TEST009 ---
@@ -170,7 +170,7 @@ sh sqlci -i "TEST009(select_stmts)";
select catalog_name, schema_name, object_name from table(natablecacheentries('user','local')) order by 1,2,3;
drop external table t009t1 for hive.sch_t009.t009t1;
get tables in schema "_HV_SCH_T009_";
-select * from table(natablecacheentries('user','local')) order by 2,3,4;
+select row_id, catalog_name, schema_name, object_name from table(natablecacheentries('user','local')) order by 2,3,4;
--- End diff --
Thanks, good point, I'll add that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---