You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by fe...@apache.org on 2017/05/05 15:30:47 UTC

spark git commit: [SPARK-20613] Remove excess quotes in Windows executable

Repository: spark
Updated Branches:
  refs/heads/master 9064f1b04 -> b9ad2d191


[SPARK-20613] Remove excess quotes in Windows executable

## What changes were proposed in this pull request?

Quotes are already added to the RUNNER variable on line 54. There is no need to put quotes on line 67. If you do, you will get an error when launching Spark.

'""C:\Program' is not recognized as an internal or external command, operable program or batch file.

## How was this patch tested?

Tested manually on Windows 10.

Author: Jarrett Meyer <ja...@gmail.com>

Closes #17861 from jarrettmeyer/fix-windows-cmd.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/b9ad2d19
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/b9ad2d19
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/b9ad2d19

Branch: refs/heads/master
Commit: b9ad2d1916af5091c8585d06ccad8219e437e2bc
Parents: 9064f1b
Author: Jarrett Meyer <ja...@gmail.com>
Authored: Fri May 5 08:30:42 2017 -0700
Committer: Felix Cheung <fe...@apache.org>
Committed: Fri May 5 08:30:42 2017 -0700

----------------------------------------------------------------------
 bin/spark-class2.cmd | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/b9ad2d19/bin/spark-class2.cmd
----------------------------------------------------------------------
diff --git a/bin/spark-class2.cmd b/bin/spark-class2.cmd
index 9faa7d6..f6157f4 100644
--- a/bin/spark-class2.cmd
+++ b/bin/spark-class2.cmd
@@ -51,7 +51,7 @@ if not "x%SPARK_PREPEND_CLASSES%"=="x" (
 rem Figure out where java is.
 set RUNNER=java
 if not "x%JAVA_HOME%"=="x" (
-  set RUNNER="%JAVA_HOME%\bin\java"
+  set RUNNER=%JAVA_HOME%\bin\java
 ) else (
   where /q "%RUNNER%"
   if ERRORLEVEL 1 (


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org