You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/07/17 06:12:42 UTC
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request, #1220: Add printflike to all printf like functions
xiaoxiang781216 opened a new pull request, #1220:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1220
## Summary
Follow the similar kernel change: https://github.com/apache/incubator-nuttx/pull/6632
## Impact
Enable more compiler time check
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1220: Add printflike to all printf like functions
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #1220:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1220: Add printflike to all printf like functions
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1220:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1220#discussion_r923080748
##########
interpreters/bas/bas_statement.c:
##########
@@ -1241,7 +1241,7 @@ struct Value *stmt_EDIT(struct Value *value)
return (struct Value *)0;
#else
- return Value_new_ERROR(value, NOTAVAILABLE, strerror(ENOSYS));
+ return Value_new_ERROR(value, NOTAVAILABLE);
Review Comment:
Maybe modify `#define NOTAVAILABLE RUNTIME+22,_("Feature not available")` to `#define NOTAVAILABLE RUNTIME+22,_("Feature not available %s")` similar to `STRAYSUBEXIT`?
However only `strerror(ENOSYS)` is printed, so does not make sense now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1220: Add printflike to all printf like functions
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1220:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1220#discussion_r923051896
##########
nshlib/nsh_netcmds.c:
##########
@@ -377,8 +377,8 @@ static int nsh_foreach_netdev(nsh_netdev_callback_t callback,
if (dir == NULL)
{
nsh_error(vtbl,
- "nsh: %s: Could not open %s/net (is procfs mounted?): %d\n",
- cmd, CONFIG_NSH_PROC_MOUNTPOINT, NSH_ERRNO);
Review Comment:
NSH_ERRNO may be a string or an integer:
https://github.com/apache/incubator-nuttx-apps/blob/master/nshlib/nsh.h#L434-L444
it's hard to keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1220: Add printflike to all printf like functions
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #1220:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1220#issuecomment-1186550006
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1220: Add printflike to all printf like functions
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #1220:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1220#issuecomment-1186534540
There still are few build errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1220: Add printflike to all printf like functions
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1220:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1220#discussion_r923040660
##########
nshlib/nsh_netcmds.c:
##########
@@ -377,8 +377,8 @@ static int nsh_foreach_netdev(nsh_netdev_callback_t callback,
if (dir == NULL)
{
nsh_error(vtbl,
- "nsh: %s: Could not open %s/net (is procfs mounted?): %d\n",
- cmd, CONFIG_NSH_PROC_MOUNTPOINT, NSH_ERRNO);
Review Comment:
Why printing of NSH_ERRNO is removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1220: Add printflike to all printf like functions
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #1220:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1220#issuecomment-1186454576
Please ignore the mix case warning in:
https://github.com/apache/incubator-nuttx-apps/runs/7376553170?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1220: Add printflike to all printf like functions
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #1220:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1220#issuecomment-1186963942
> @xiaoxiang781216 do you have any guess about reason of check error at examples/sotest/lib/sotest/sotest.c#L58 ?
that's because nxstyle consider `,` in the string as the multiple variables defined in the same line:
```
static const char g_msg3[] = "Yes, don't be a stranger!";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1220: Add printflike to all printf like functions
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #1220:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1220#issuecomment-1186940288
@xiaoxiang781216 do you have any guess about reason of check error at examples/sotest/lib/sotest/sotest.c#L58 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1220: Add printflike to all printf like functions
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #1220:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1220#issuecomment-1186575619
```
In file included from nsh_syscmds.c:38:
nsh_syscmds.c: In function 'cmd_pmconfig':
Error: nsh_syscmds.c:220:24: error: format '%d' expects argument of type 'int', but argument 3 has type 'char *' [-Werror=format=]
220 | nsh_output(vtbl, "Last state %d, Next state %d",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
221 | "PM stay [%d, %d, %d, %d]\n",
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| char *
nsh_console.h:53:49: note: in definition of macro 'nsh_output'
53 | # define nsh_output(v, ...) (v)->output(v, ##__VA_ARGS__)
| ^~~~~~~~~~~
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1220: Add printflike to all printf like functions
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1220:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1220#discussion_r923097119
##########
interpreters/bas/bas_statement.c:
##########
@@ -1241,7 +1241,7 @@ struct Value *stmt_EDIT(struct Value *value)
return (struct Value *)0;
#else
- return Value_new_ERROR(value, NOTAVAILABLE, strerror(ENOSYS));
+ return Value_new_ERROR(value, NOTAVAILABLE);
Review Comment:
Yes, I think so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1220: Add printflike to all printf like functions
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1220:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1220#discussion_r923065479
##########
nshlib/nsh_netcmds.c:
##########
@@ -377,8 +377,8 @@ static int nsh_foreach_netdev(nsh_netdev_callback_t callback,
if (dir == NULL)
{
nsh_error(vtbl,
- "nsh: %s: Could not open %s/net (is procfs mounted?): %d\n",
- cmd, CONFIG_NSH_PROC_MOUNTPOINT, NSH_ERRNO);
Review Comment:
Ok, I remove else keyword, so the errno will output too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org