You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/13 06:02:58 UTC
[GitHub] [pulsar] lhotari opened a new pull request #10209: [Test] Fix TCP port conflicts in tests
lhotari opened a new pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209
### Motivation
There are some tests that fail because of port conflicts. Fixed ports 6650, 6651 and 8080 get used in a few tests.
### Modifications
- Change the tests to use dynamic ports.
- While making changes to LeaderElectionServiceTest, make it thread safe
- It's not thread safe to modify Mockito mocks after they have been published to another thread. Change the logic to use AtomicBoolean and AtomicReference classes to achieve the desired result.
- While making changes to PulsarMultiListenersWith*InternalListenerNameTests, make PulsarMultiListenersWithoutInternalListenerNameTest class extend PulsarMultiListenersWithInternalListenerNameTest class to reduce test code duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-819130676
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-819059846
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-818714067
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-819130676
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-818762497
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-819949192
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-818542177
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-818762497
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-819059846
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-818584442
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-818584442
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-820026028
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-819883289
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-819198098
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-819683548
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-818688094
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-818542177
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-819288371
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-819198098
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-819258165
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-820026028
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-820682285
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-819683548
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-818714067
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-820736048
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-819803017
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-819949192
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-818688094
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-819471876
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-819803017
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-819326380
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-819883289
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-819471876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-819258165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-819509323
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10209: [Tests] Fix TCP port conflicts in tests
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10209:
URL: https://github.com/apache/pulsar/pull/10209#issuecomment-820682285
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org