You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/29 01:42:39 UTC
[GitHub] [spark] yoda-mon opened a new pull request #34135: [SPARK-36882][PYTHON]Support ILIKE API on Python
yoda-mon opened a new pull request #34135:
URL: https://github.com/apache/spark/pull/34135
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Support ILIKE (case insensitive LIKE) API on Python.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
ILIKE statement on SQL interface is supported by SPARK-36674.
This PR will support Python API for it.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. Users can call `ilike` from Python.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929826783
@yoda-mon, FYI, there's a R linter failure going up globally that seems like an issue from external server (e.g., CRAN). So feel free to ignore it for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34135:
URL: https://github.com/apache/spark/pull/34135#discussion_r718085839
##########
File path: python/pyspark/sql/column.py
##########
@@ -507,6 +507,24 @@ def __iter__(self):
>>> df.filter(df.name.like('Al%')).collect()
[Row(age=2, name='Alice')]
"""
+ _ilike_doc = """
+ SQL ILIKE expression (case insensitive LIKE). Returns a boolean :class:`Column`
+ based on a case insensitive match.
+
Review comment:
I know it is consistent with other places in the docs but let's add versionadded directive. I think we should add them actually for all places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929820765
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48208/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929827004
**[Test build #143701 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143701/testReport)** for PR 34135 at commit [`a9a4377`](https://github.com/apache/spark/commit/a9a43773bd451a889b54ed7f6638f79a8e03c521).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929769041
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143693/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yoda-mon commented on a change in pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
yoda-mon commented on a change in pull request #34135:
URL: https://github.com/apache/spark/pull/34135#discussion_r718089187
##########
File path: python/pyspark/sql/column.py
##########
@@ -507,6 +507,24 @@ def __iter__(self):
>>> df.filter(df.name.like('Al%')).collect()
[Row(age=2, name='Alice')]
"""
+ _ilike_doc = """
+ SQL ILIKE expression (case insensitive LIKE). Returns a boolean :class:`Column`
+ based on a case insensitive match.
+
Review comment:
Thank you, I'm also concerned about the versionadded directive... I will add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929845138
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143703/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929827446
**[Test build #143701 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143701/testReport)** for PR 34135 at commit [`a9a4377`](https://github.com/apache/spark/commit/a9a43773bd451a889b54ed7f6638f79a8e03c521).
* This patch **fails Python style tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `public final class TableIndex `
* `class IndexAlreadyExistsException(indexName: String, table: Identifier)`
* `class NoSuchIndexException(indexName: String)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak closed pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
sarutak closed pull request #34135:
URL: https://github.com/apache/spark/pull/34135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929827004
**[Test build #143701 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143701/testReport)** for PR 34135 at commit [`a9a4377`](https://github.com/apache/spark/commit/a9a43773bd451a889b54ed7f6638f79a8e03c521).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929754383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929827498
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143701/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929879407
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48217/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929820765
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48208/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929863875
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48216/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929879407
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48217/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929862915
Merged to `master`. Thank you @yoda-mon @HyukjinKwon @MaxGekk !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929789935
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48208/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929826783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929754383
**[Test build #143692 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143692/testReport)** for PR 34135 at commit [`950e7c5`](https://github.com/apache/spark/commit/950e7c5430d5a194bf1a9a863123bd3407b3e1d7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929879361
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48217/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929870858
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48216/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929850767
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48217/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34135:
URL: https://github.com/apache/spark/pull/34135#discussion_r718085839
##########
File path: python/pyspark/sql/column.py
##########
@@ -507,6 +507,24 @@ def __iter__(self):
>>> df.filter(df.name.like('Al%')).collect()
[Row(age=2, name='Alice')]
"""
+ _ilike_doc = """
+ SQL ILIKE expression (case insensitive LIKE). Returns a boolean :class:`Column`
+ based on a case insensitive match.
+
Review comment:
I know it is consistent with other places in the docs but let's add versionadded directive. I think we should add them actually for all places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929802309
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48207/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929754383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929833737
**[Test build #143703 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143703/testReport)** for PR 34135 at commit [`886a5f0`](https://github.com/apache/spark/commit/886a5f0828f93b27947f1f14d983184dc53e8814).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929754383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929810397
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48208/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak closed pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
sarutak closed pull request #34135:
URL: https://github.com/apache/spark/pull/34135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929827498
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143701/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929766951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929844882
**[Test build #143703 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143703/testReport)** for PR 34135 at commit [`886a5f0`](https://github.com/apache/spark/commit/886a5f0828f93b27947f1f14d983184dc53e8814).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929802309
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48207/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929802281
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48207/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929768657
**[Test build #143693 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143693/testReport)** for PR 34135 at commit [`8478880`](https://github.com/apache/spark/commit/8478880fdc9515bb842203adc20d2983901be5e3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929845810
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48216/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929870858
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48216/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929862915
Merged to `master`. Thank you @yoda-mon @HyukjinKwon @MaxGekk !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929826887
cc @MaxGekk too FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929852797
I'll leave it to @sarutak.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929766951
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143692/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yoda-mon commented on a change in pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
yoda-mon commented on a change in pull request #34135:
URL: https://github.com/apache/spark/pull/34135#discussion_r718089187
##########
File path: python/pyspark/sql/column.py
##########
@@ -507,6 +507,24 @@ def __iter__(self):
>>> df.filter(df.name.like('Al%')).collect()
[Row(age=2, name='Alice')]
"""
+ _ilike_doc = """
+ SQL ILIKE expression (case insensitive LIKE). Returns a boolean :class:`Column`
+ based on a case insensitive match.
+
Review comment:
Thank you, I'm also concerned about the versionadded directive... I will add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929845138
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143703/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929766951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929766951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929774995
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48207/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929769026
**[Test build #143693 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143693/testReport)** for PR 34135 at commit [`8478880`](https://github.com/apache/spark/commit/8478880fdc9515bb842203adc20d2983901be5e3).
* This patch **fails Python style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929765636
**[Test build #143692 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143692/testReport)** for PR 34135 at commit [`950e7c5`](https://github.com/apache/spark/commit/950e7c5430d5a194bf1a9a863123bd3407b3e1d7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34135: [SPARK-36882][PYTHON] Support ILIKE API on Python
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34135:
URL: https://github.com/apache/spark/pull/34135#issuecomment-929833737
**[Test build #143703 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143703/testReport)** for PR 34135 at commit [`886a5f0`](https://github.com/apache/spark/commit/886a5f0828f93b27947f1f14d983184dc53e8814).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org