[GitHub] [airflow] hsrocks commented on pull request #21073: Feature : Implement a AWS Session manager Parameter Store Operators and hooks

[GitBox <gi...@apache.org>]

hsrocks commented on pull request #21073:
URL: https://github.com/apache/airflow/pull/21073#issuecomment-1060691109


   > hey @hsrocks - sorry for the delay, I think you should take a look how Hashicorp Vault is implemented. It has very similar story. And what we came up with is:
   > 
   > Internal Client that is reused by both Hook and Secret Manager:
   > 
   > * https://github.com/apache/airflow/blob/main/airflow/providers/hashicorp/_internal_client/vault_client.py
   > 
   > Hook (which is a thin wrapper over the client):
   > 
   > * https://github.com/apache/airflow/blob/main/airflow/providers/hashicorp/hooks/vault.py
   > 
   > Secrets Manager (which is a thin wrapper over the client):
   > 
   > * https://github.com/apache/airflow/blob/main/airflow/providers/hashicorp/secrets/vault.py
   > 
   > Duplication is minimized (and we've already implemented some features in client that were automatically available to both SecretManager and Hook (see the history of "vault_client.py" - proving that this pattern is really good.
   
   Thanks for the Awesome pointers @potiuk ! Appreciate the level of details. Will go through them and implement this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org