You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@aries.apache.org by am...@apache.org on 2026/05/17 08:47:31 UTC
(aries-rsa) 01/05: Inline TopologyManagerExport methods
This is an automated email from the ASF dual-hosted git repository.
amichair pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/aries-rsa.git
commit a6f7c9408787f802b9f83703970cd1450e1636e7
Author: Amichai Rothman <am...@apache.org>
AuthorDate: Thu Mar 26 17:44:26 2026 +0200
Inline TopologyManagerExport methods
---
.../exporter/TopologyManagerExport.java | 24 ++++++----------------
1 file changed, 6 insertions(+), 18 deletions(-)
diff --git a/topology-manager/src/main/java/org/apache/aries/rsa/topologymanager/exporter/TopologyManagerExport.java b/topology-manager/src/main/java/org/apache/aries/rsa/topologymanager/exporter/TopologyManagerExport.java
index 7db6647a..4baf626e 100644
--- a/topology-manager/src/main/java/org/apache/aries/rsa/topologymanager/exporter/TopologyManagerExport.java
+++ b/topology-manager/src/main/java/org/apache/aries/rsa/topologymanager/exporter/TopologyManagerExport.java
@@ -87,40 +87,28 @@ public class TopologyManagerExport implements ServiceListener {
public void serviceChanged(ServiceEvent event) {
ServiceReference<?> sref = event.getServiceReference();
if (!shouldExport(sref)) {
- LOG.trace("Skipping service {}", sref);
+ LOG.trace("ignoring service {}", sref);
return;
}
LOG.info("Received ServiceEvent type: {}, sref: {}", getTypeName(event), sref);
switch (event.getType()) {
case ServiceEvent.REGISTERED:
- add(sref);
+ exportable.add(sref);
+ export(sref);
break;
case ServiceEvent.MODIFIED:
- modified(sref);
+ endpointRepo.values().forEach(repo -> repo.modifyService(sref));
break;
case ServiceEvent.UNREGISTERING:
case ServiceEvent.MODIFIED_ENDMATCH:
- remove(sref);
+ exportable.remove(sref);
+ endpointRepo.values().forEach(repo -> repo.removeService(sref));
break;
}
}
- private void add(ServiceReference<?> sref) {
- exportable.add(sref);
- export(sref);
- }
-
- private void modified(ServiceReference<?> sref) {
- endpointRepo.values().forEach(repo -> repo.modifyService(sref));
- }
-
- private void remove(ServiceReference<?> sref) {
- exportable.remove(sref);
- endpointRepo.values().forEach(repo -> repo.removeService(sref));
- }
-
public void add(RemoteServiceAdmin rsa) {
endpointRepo.put(rsa, new ServiceExportsRepository(rsa, notifier));
exportable.forEach(sref -> executor.execute(() -> export(sref)));