You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/07/14 19:28:32 UTC
[GitHub] [airflow] kaxil opened a new pull request #9822: Add note in Updating.md about the change in `run_as_user` default
kaxil opened a new pull request #9822:
URL: https://github.com/apache/airflow/pull/9822
Until Airflow 1.10.10 the default run_as_user config (https://airflow.readthedocs.io/en/1.10.10/configurations-ref.html#run-as-user) which defaulted it to root user `0` (https://github.com/apache/airflow/blob/96697180d79bfc90f6964a8e99f9dd441789177c/airflow/contrib/executors/kubernetes_executor.py#L295-L301)
In Airflow 1.10.11 we changed it to `50000`
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #9822: Add note in Updating.md about the change in `run_as_user` default
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #9822:
URL: https://github.com/apache/airflow/pull/9822
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #9822: Add note in Updating.md about the change in `run_as_user` default
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #9822:
URL: https://github.com/apache/airflow/pull/9822#discussion_r454635632
##########
File path: UPDATING.md
##########
@@ -1476,6 +1476,28 @@ auth_backend = airflow.api.auth.backend.default
Since XCom values can contain pickled data, we would no longer allow adding or
changing XCom values from the UI.
+### Default for `run_as_user` configured has been changed to 50000 from 0
Review comment:
FYI this is in Airflow 1.10.11 section
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #9822: Add note in Updating.md about the change in `run_as_user` default
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #9822:
URL: https://github.com/apache/airflow/pull/9822#issuecomment-658773453
Apparently it's been changed in this change here https://github.com/apache/airflow/commit/23d5ea0780898c9b7e3c40a402eea148e0438046 as part of switching Kubernetes to production image. Since we want to "promote" prod image use probably it is a good idea.
However tt might be somewhat unexpected for someone who does not use the official production image - so for sure we need to document it in updating.
Note also that it is not strictly necessary in the current image (1.10.11+) - since the image is openshift-compatible, you can run airflow with any UID as long as it belongs to "root" group.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org