You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/01/31 22:58:25 UTC
Review Request: Fixes issues with running the killtree.sh script.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3710/
-----------------------------------------------------------
Review request for mesos, Charles Reiss, John Sirois, and Vinod Kone.
Summary
-------
The slave was having problems launching the killtree.sh script, which looks to have caused crashes. These fixes should address those issues.
Diffs
-----
bin/mesos-build-env.sh.in 675e713
src/common/process_utils.hpp ffa1648
src/common/utils.hpp bb9cd3f
Diff: https://reviews.apache.org/r/3710/diff
Testing
-------
Thanks,
Benjamin
Re: Review Request: Fixes issues with running the killtree.sh script.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3710/#review4712
-----------------------------------------------------------
src/common/utils.hpp
<https://reviews.apache.org/r/3710/#comment10435>
I'll remove this.
- Benjamin
On 2012-01-31 22:05:22, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3710/
> -----------------------------------------------------------
>
> (Updated 2012-01-31 22:05:22)
>
>
> Review request for mesos, Charles Reiss, John Sirois, and Vinod Kone.
>
>
> Summary
> -------
>
> The slave was having problems launching the killtree.sh script, which looks to have caused crashes. These fixes should address those issues.
>
>
> Diffs
> -----
>
> bin/mesos-build-env.sh.in 675e713
> src/common/process_utils.hpp ffa1648
> src/common/utils.hpp bb9cd3f
>
> Diff: https://reviews.apache.org/r/3710/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Fixes issues with running the killtree.sh script.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On 2012-01-31 22:10:06, Vinod Kone wrote:
> >
Thanks Vinod, submitting.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3710/#review4714
-----------------------------------------------------------
On 2012-01-31 22:05:22, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3710/
> -----------------------------------------------------------
>
> (Updated 2012-01-31 22:05:22)
>
>
> Review request for mesos, Charles Reiss, John Sirois, and Vinod Kone.
>
>
> Summary
> -------
>
> The slave was having problems launching the killtree.sh script, which looks to have caused crashes. These fixes should address those issues.
>
>
> Diffs
> -----
>
> bin/mesos-build-env.sh.in 675e713
> src/common/process_utils.hpp ffa1648
> src/common/utils.hpp bb9cd3f
>
> Diff: https://reviews.apache.org/r/3710/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Fixes issues with running the killtree.sh script.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3710/#review4714
-----------------------------------------------------------
Ship it!
- Vinod
On 2012-01-31 22:05:22, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3710/
> -----------------------------------------------------------
>
> (Updated 2012-01-31 22:05:22)
>
>
> Review request for mesos, Charles Reiss, John Sirois, and Vinod Kone.
>
>
> Summary
> -------
>
> The slave was having problems launching the killtree.sh script, which looks to have caused crashes. These fixes should address those issues.
>
>
> Diffs
> -----
>
> bin/mesos-build-env.sh.in 675e713
> src/common/process_utils.hpp ffa1648
> src/common/utils.hpp bb9cd3f
>
> Diff: https://reviews.apache.org/r/3710/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Fixes issues with running the killtree.sh script.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3710/
-----------------------------------------------------------
(Updated 2012-01-31 22:05:22.515656)
Review request for mesos, Charles Reiss, John Sirois, and Vinod Kone.
Changes
-------
Added wrong diff, updated.
Summary
-------
The slave was having problems launching the killtree.sh script, which looks to have caused crashes. These fixes should address those issues.
Diffs (updated)
-----
bin/mesos-build-env.sh.in 675e713
src/common/process_utils.hpp ffa1648
src/common/utils.hpp bb9cd3f
Diff: https://reviews.apache.org/r/3710/diff
Testing
-------
Thanks,
Benjamin