[Bug 61309] New: Refactoring of SampleSaveConfiguration

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61309

            Bug ID: 61309
           Summary: Refactoring of SampleSaveConfiguration
           Product: JMeter
           Version: 3.0
          Hardware: PC
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Main
          Assignee: issues@jmeter.apache.org
          Reporter: lemesmachado@gmail.com
  Target Milestone: ---

Hello everyone.
I was analyzing the modularization of some classes, and I identified that the
class SampleSaveConfiguration has an opportunity for cohesion improvement. 
The class SaveService was in the same situation and the problem was solved as
follows: The OldSaveService class was created, and several get() and set()
methods that were used only to configure the class parameters were moved from
SaveService to OldSaveService. 
The new class was then accessed through an instance variable in SaveService.
This strategy has cleaned and improved SaveService cohesion.
With this in mind, I would recommend creating a new class:
SampleSaveConfigurationConfig , and moving the following methods:

setAssertions
setResponseHeaders
getVarCount
setFileName
setSuccess
getXmlPi
getDelimiter
setRequestHeaders
setAssertionResultsFailureMessage
setEncoding
setBytes
setTime
setSamplerData
setDataType
setThreadName
setVarCount
setFieldNames
setSubresults
setHostname
setSampleCount
setDelimiter
setIdleTime
setUrl
setThreadCounts
setConnectTime
setTimestamp
setDefaultTimeStampFormat
setCode
setAsXml
setMessage
setLatency
setResponseData
setDefaultDelimiter
setLabel
setFormatter


from the SampleSaveConfiguration.
Those parameters accessed by an instance variable in the
SampleSaveConfiguration.
Moreover, the orthogonality is the design would be enhanced.

What do you think about that?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 61309] Refactoring of SampleSaveConfiguration

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61309

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All
         Resolution|---                         |WONTFIX
             Status|NEW                         |RESOLVED
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om

--- Comment #1 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Thanks for proposal, but approach seems to theorical for me and we have to make
some choices regarding our time.
Unless you propose a PR and impact does not break all plugins , I doubt we will
move on this.
Closing as WONTFIX.

Thank you

-- 
You are receiving this mail because:
You are the assignee for the bug.