You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "frankgh (via GitHub)" <gi...@apache.org> on 2024/12/22 22:15:25 UTC
[PR] CASSSIDECAR-182: Refactor access to delegate methods to simplify [cassandra-sidecar]
frankgh opened a new pull request, #168:
URL: https://github.com/apache/cassandra-sidecar/pull/168
Patch by Francisco Guerrero; Reviewed by Yifan Cai for CASSSIDECAR-182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSSIDECAR-182: Refactor access to delegate methods to simplify [cassandra-sidecar]
Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh merged PR #168:
URL: https://github.com/apache/cassandra-sidecar/pull/168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSSIDECAR-182: Refactor access to delegate methods to simplify [cassandra-sidecar]
Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh commented on PR #168:
URL: https://github.com/apache/cassandra-sidecar/pull/168#issuecomment-2563334894
> I am feeling neutral about the patch. If I were to refactor the code, I would rather ensure the getters of `CassandraAdapterDelegate` return non-null result or throws proper exception. Returning null only transfers the handling to the callsites, and most of the callsites handle `null` case the same way by throwing exception. For certain scenarios that `null` is expected, the delegate can expose `xxxOrNull` methods (which are the same as the current ones).
>
> There are 2 problems with the new methods introduced in this patch, (e.g. `ifAvailableFromDelegate`). First, they are complex. Second, they cannot be easily discovered, since one has to pair those helpers with the concrete getters.
I agree with you . I tried with the direction you suggested and applied the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org