[GitHub] ilooner commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few

[GitBox <gi...@apache.org>]

ilooner commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few
URL: https://github.com/apache/drill/pull/1606#discussion_r246666262
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinMemoryCalculator.java
 ##########
 @@ -154,6 +151,9 @@ void initialize(boolean firstCycle,
     long getInMemorySize();
   }
 
+  interface HashJoinSpillControl {
+    boolean shouldSpill(VectorContainer currentVectorContainer);
 
 Review comment:
   The argument currentVectorContainer shouldn't be required. So the signature should be
   
   ```
   boolean shouldSpill();
   ```
   
   For details about why we don't need the arg see my comment on HashJoinSpillControl

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services