[GitHub] [tvm] Hzfengsy commented on a change in pull request #10335: [TIR] Misc minor updates

[GitBox <gi...@apache.org>]

Hzfengsy commented on a change in pull request #10335:
URL: https://github.com/apache/tvm/pull/10335#discussion_r811510987



##########
File path: src/tir/ir/stmt_functor.cc
##########
@@ -700,10 +700,11 @@ Array<Range> Substitute(const Array<Range>& region, const Map<Var, PrimExpr>& vm
 }
 
 void PreOrderVisit(const ObjectRef& stmt_or_expr,
-                   const std::function<bool(const ObjectRef&)>& fvisit) {
+                   const std::function<bool(const ObjectRef&)>& fvisit, bool visit_init_block) {

Review comment:
       I think it makes no sense to add a parameter in the base class to determine if we visit the init block. Write an additional visitor may be a better choice.

##########
File path: include/tvm/tir/stmt.h
##########
@@ -1400,6 +1394,54 @@ constexpr const char* meta_schedule_unroll_explicit = "meta_schedule.unroll_expl
 /*! \brief Mark auto-unroll setting on the block. */
 constexpr const char* meta_schedule_unroll_implicit = "meta_schedule.unroll_implicit";
 
+/*!
+ * \brief Mark that the block need to add predicate for block var bounds during lowering
+ */
+constexpr const char* require_block_var_bound_predicate = "require_bound_predicate";
+
+/*!
+ * \brief Mark that the block should be further rewritten using tensorization.
+ */
+constexpr const char* meta_schedule_auto_tensorize = "meta_schedule.auto_tensorize";

Review comment:
       Some annotations are not needed for now




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org