[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #691: [core] Use enum instead of string for file.format

["JingsongLi (via GitHub)" <gi...@apache.org>]

JingsongLi commented on code in PR #691:
URL: https://github.com/apache/incubator-paimon/pull/691#discussion_r1144661797


##########
paimon-core/src/main/java/org/apache/paimon/CoreOptions.java:
##########
@@ -956,6 +962,31 @@ public InlineElement getDescription() {
         }
     }
 
+    /** Specifies the file format type for store. */
+    public enum FileFormatType implements DescribedEnum {
+        ORC("orc", "ORC format for file store."),

Review Comment:
   maybe remove `file store`? now log store is only in flink



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org