[jira] [Commented] (LUCENE-3765) trappy ignoreCase behavior with StopFilter/ignoreCase

["Robert Muir (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204534#comment-13204534 ] 

Robert Muir commented on LUCENE-3765:
-------------------------------------

Also, for 4.0 i think we should go a step further and remove all this Set<?>/Set<Object> crap/instanceof/copying

instead stopfilter, etc should just take chararrayset, and this is what makestopset should return.

I'll update the patch. for 3.x we can just deprecate the two confusing nuked' ctors from the first patch above...
so we can still make some improvement there.
                
> trappy ignoreCase behavior with StopFilter/ignoreCase
> -----------------------------------------------------
>
>                 Key: LUCENE-3765
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3765
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: modules/analysis
>            Reporter: Robert Muir
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3765.patch
>
>
> Spinoff from LUCENE-3751:
> {code}
> * If <code>stopWords</code> is an instance of {@link CharArraySet} (true if
> * <code>makeStopSet()</code> was used to construct the set) it will be
> * directly used and <code>ignoreCase</code> will be ignored since
> * <code>CharArraySet</code> directly controls case sensitivity.
> {code}
> This is really confusing and trappy... we need to change something here.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org