You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Aleksandr Kovalenko <ak...@hortonworks.com> on 2014/10/10 17:53:38 UTC

Review Request 26558: Slider View: Provide more detailed tooltips for view parameters

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26558/
-----------------------------------------------------------

Review request for Ambari, Andriy Babiichuk and Andrii Tkach.


Bugs: AMBARI-7730
    https://issues.apache.org/jira/browse/AMBARI-7730


Repository: ambari


Description
-------

The tooltip message should be aligned to the left (not center). 

Also, the following tooltip should be used for the parameters
slider.userUser this view instance should run as. Specifying an empty value runs view as YARN service user (for example 'yarn'). Specifying '${username}' runs the view as the currently logged in user. Specifying any other value runs the view as that user. 

Administrators should check that the HDFS home folder for that user is created and accessible.
iew.kerberos.principal - Kerberos principal associated with this view. For example: ambari/_HOST@EXAMPLE.COM.

Administrators should make sure that HDFS service has the 'hadoop.proxyuser.[user].groups' and 'hadoop.proxyuser.[user].hosts' configs populated in 'core-site.xml'.
view.kerberos.principal.keytab - Path to the Kerberos principal keytab used for view's user. For example: /etc/security/keytabs/ambari.headless.keytab

Administrators should make sure that HDFS service has the 'hadoop.proxyuser.[user].groups' and 'hadoop.proxyuser.[user].hosts' configs populated in 'core-site.xml'.


Diffs
-----

  ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js 40a90c8 
  ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css bd2a18a 
  ambari-web/ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/ambariViews/CreateViewInstanceCtrl_test.js PRE-CREATION 
  contrib/views/slider/src/main/resources/view.xml cf86d6a 

Diff: https://reviews.apache.org/r/26558/diff/


Testing
-------

tested on real cluster


Thanks,

Aleksandr Kovalenko


Re: Review Request 26558: Slider View: Provide more detailed tooltips for view parameters

Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26558/#review56151
-----------------------------------------------------------

Ship it!


Ship It!

- Andriy Babiichuk


On Окт. 10, 2014, 3:53 п.п., Aleksandr Kovalenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26558/
> -----------------------------------------------------------
> 
> (Updated Окт. 10, 2014, 3:53 п.п.)
> 
> 
> Review request for Ambari, Andriy Babiichuk and Andrii Tkach.
> 
> 
> Bugs: AMBARI-7730
>     https://issues.apache.org/jira/browse/AMBARI-7730
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The tooltip message should be aligned to the left (not center). 
> 
> Also, the following tooltip should be used for the parameters
> slider.userUser this view instance should run as. Specifying an empty value runs view as YARN service user (for example 'yarn'). Specifying '${username}' runs the view as the currently logged in user. Specifying any other value runs the view as that user. 
> 
> Administrators should check that the HDFS home folder for that user is created and accessible.
> iew.kerberos.principal - Kerberos principal associated with this view. For example: ambari/_HOST@EXAMPLE.COM.
> 
> Administrators should make sure that HDFS service has the 'hadoop.proxyuser.[user].groups' and 'hadoop.proxyuser.[user].hosts' configs populated in 'core-site.xml'.
> view.kerberos.principal.keytab - Path to the Kerberos principal keytab used for view's user. For example: /etc/security/keytabs/ambari.headless.keytab
> 
> Administrators should make sure that HDFS service has the 'hadoop.proxyuser.[user].groups' and 'hadoop.proxyuser.[user].hosts' configs populated in 'core-site.xml'.
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js 40a90c8 
>   ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css bd2a18a 
>   ambari-web/ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/ambariViews/CreateViewInstanceCtrl_test.js PRE-CREATION 
>   contrib/views/slider/src/main/resources/view.xml cf86d6a 
> 
> Diff: https://reviews.apache.org/r/26558/diff/
> 
> 
> Testing
> -------
> 
> tested on real cluster
> 
> 
> Thanks,
> 
> Aleksandr Kovalenko
> 
>


Re: Review Request 26558: Slider View: Provide more detailed tooltips for view parameters

Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26558/#review56152
-----------------------------------------------------------

Ship it!


Ship It!

- Andrii Tkach


On Окт. 10, 2014, 3:53 п.п., Aleksandr Kovalenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26558/
> -----------------------------------------------------------
> 
> (Updated Окт. 10, 2014, 3:53 п.п.)
> 
> 
> Review request for Ambari, Andriy Babiichuk and Andrii Tkach.
> 
> 
> Bugs: AMBARI-7730
>     https://issues.apache.org/jira/browse/AMBARI-7730
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The tooltip message should be aligned to the left (not center). 
> 
> Also, the following tooltip should be used for the parameters
> slider.userUser this view instance should run as. Specifying an empty value runs view as YARN service user (for example 'yarn'). Specifying '${username}' runs the view as the currently logged in user. Specifying any other value runs the view as that user. 
> 
> Administrators should check that the HDFS home folder for that user is created and accessible.
> iew.kerberos.principal - Kerberos principal associated with this view. For example: ambari/_HOST@EXAMPLE.COM.
> 
> Administrators should make sure that HDFS service has the 'hadoop.proxyuser.[user].groups' and 'hadoop.proxyuser.[user].hosts' configs populated in 'core-site.xml'.
> view.kerberos.principal.keytab - Path to the Kerberos principal keytab used for view's user. For example: /etc/security/keytabs/ambari.headless.keytab
> 
> Administrators should make sure that HDFS service has the 'hadoop.proxyuser.[user].groups' and 'hadoop.proxyuser.[user].hosts' configs populated in 'core-site.xml'.
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js 40a90c8 
>   ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css bd2a18a 
>   ambari-web/ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/ambariViews/CreateViewInstanceCtrl_test.js PRE-CREATION 
>   contrib/views/slider/src/main/resources/view.xml cf86d6a 
> 
> Diff: https://reviews.apache.org/r/26558/diff/
> 
> 
> Testing
> -------
> 
> tested on real cluster
> 
> 
> Thanks,
> 
> Aleksandr Kovalenko
> 
>