You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Mamta A. Satoor (JIRA)" <ji...@apache.org> on 2008/06/11 06:36:45 UTC
[jira] Resolved: (DERBY-3338) CancelQueryTask.forgetContext() could
be simplified.
[ https://issues.apache.org/jira/browse/DERBY-3338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mamta A. Satoor resolved DERBY-3338.
------------------------------------
Resolution: Fixed
Fix Version/s: 10.5.0.0
Thanks, Dag, for the review. I have committed the changes into trunk with revision 666519.
> CancelQueryTask.forgetContext() could be simplified.
> ----------------------------------------------------
>
> Key: DERBY-3338
> URL: https://issues.apache.org/jira/browse/DERBY-3338
> Project: Derby
> Issue Type: Improvement
> Components: Newcomer, Services, SQL
> Reporter: Daniel John Debrunner
> Assignee: Mamta A. Satoor
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: DERBY_3338_rework_forgetContext_v1.diff
>
>
> Minor issue but CancelQueryTask.forgetContext() has this code (in GenericStatementContext.java)
> public void forgetContext() {
> boolean mayStillRun = !cancel();
> if (mayStillRun) {
> synchronized (this) {
> statementContext = null;
> }
> }
> }
> The mayStillRun = !cancel() is somewhat confusing. I can't see from the javadoc of TimerTask.cancel() how its return value could indicate the task may still run.
> Less confusing code could be:
> public void forgetContext() {
> synchronized (this) {
> statementContext = null;
> }
> cancel();
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Resolved: (DERBY-3338) CancelQueryTask.forgetContext() could be simplified.
Posted by Mamta Satoor <ms...@gmail.com>.
Sure, I will work on porting this to 10.3 and 10.4.
Mamta
On 6/11/08, Myrna van Lunteren <m....@gmail.com> wrote:
> Is it feasible to backport this to at least 10.4 and 10.3?
>
> Myrna
>
Re: [jira] Resolved: (DERBY-3338) CancelQueryTask.forgetContext() could be simplified.
Posted by Myrna van Lunteren <m....@gmail.com>.
Is it feasible to backport this to at least 10.4 and 10.3?
Myrna