[jira] [Comment Edited] (LUCENE-9187) remove too-expensive assert from LZ4 HighCompressionHashTable

["Robert Muir (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-9187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17027189#comment-17027189 ] 

Robert Muir edited comment on LUCENE-9187 at 1/31/20 4:55 AM:
--------------------------------------------------------------

[~dsmiley] it refers to the linked issue that found it: LUCENE-9185

You can find these options by running {{gradlew helpTests}} which just prints this text: https://github.com/apache/lucene-solr/blob/4b5105e16798daec9f68ac333661efe1eb6d867b/help/tests.txt#L115-L142

{quote}
Profiling slow tests
--------------------

The "tests.profile" mode switch turns on a sampling profiler during test execution,
and prints a simple summary at the end.

For example, top-10 histogram of methods (cpu samples):

gradlew -p lucene/core test -Ptests.profile=true

Alternatively, you can profile heap allocations instead:

gradlew -p lucene/core test -Ptests.profile=true -Ptests.profile.mode=heap

By default, results are computed (deduplicated) on just the method name, folding
together all events from the same method. To drill down further, you can increase the
stack size from the default of 1, to get a histogram of stacktraces instead:

gradlew -p lucene/core test -Ptests.profile=true -Ptests.profile.stacksize=8

For big methods, it can also be helpful to include line numbers for more granularity:

gradlew -p lucene/core test -Ptests.profile=true -Ptests.profile.linenumbers=true

Using these additional options will make the results more sparse, so it may be useful
to increase the top-N count:

gradlew -p lucene/core test -Ptests.profile=true -Ptests.profile.count=100
{quote}

edit: fix typo, see https://github.com/apache/lucene-solr/commit/ed7f507c3ce352775725b82fb646d7187eced70e



was (Author: rcmuir):
[~dsmiley] it refers to the linked issue that found it: LUCENE-9185

You can find these options by running {{gradlew helpTests}} which just prints this text: https://github.com/apache/lucene-solr/blob/4b5105e16798daec9f68ac333661efe1eb6d867b/help/tests.txt#L115-L142

{quote}
Profiling slow tests
--------------------

The "tests.profile" mode switch turns on a sampling profiler during test execution,
and prints a simple summary at the end.

For example, top-10 histogram of methods (cpu samples):

gradlew -p lucene/core test -Ptests.profile=true

Alternatively, you can profile heap allocations instead:

gradlew -p lucene/core test -Ptests.profile=true -Ptests.profile.mode=heap

By default, results are computed (deduplicated) on just the method name, folding
together all events from the same method. To drill down further, you can increase the
stack size from the default of 1, to get a histogram of stacktraces instead:

gradlew -p lucene/core test -Ptests.profile=true -Ptests.profile.stacksize=8

For big methods, it can also be helpful to include line numbers for more granularity:

gradlew -p lucene/core test -Ptests.profile=true -Ptests.profile.linenumbers=true

Using these additional options will make the results more sparse, so it may be useful
to increase the top-N count:

gradlew -p lucene/core test -Ptests.profile=true -Ptests.count=100
{quote}



> remove too-expensive assert from LZ4 HighCompressionHashTable
> -------------------------------------------------------------
>
>                 Key: LUCENE-9187
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9187
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>            Priority: Major
>             Fix For: master (9.0)
>
>         Attachments: LUCENE-9187.patch
>
>
> This is the slowest method in the lucene tests. See LUCENE-9185 for what I mean.
> If you look at it, its checking 64k values every time the assert is called.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org