You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/11/22 11:27:09 UTC
[GitHub] [doris] priyasharma1 opened a new pull request, #14499: [Enhancement] replace assertTrue(X.equals(X)) with assertEquals (11916)
priyasharma1 opened a new pull request, #14499:
URL: https://github.com/apache/doris/pull/14499
# Proposed changes
Issue Number: close #11916
## Problem summary
Replace assertTrue(X.equals(X)) with assertEquals
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [x] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [x] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] priyasharma1 commented on pull request #14499: [Enhancement](fe) replace assertTrue(X.equals(X)) with assertEquals (11916)
Posted by GitBox <gi...@apache.org>.
priyasharma1 commented on PR #14499:
URL: https://github.com/apache/doris/pull/14499#issuecomment-1366466620
Closing this pull request as https://github.com/apache/doris/issues/11916 is closed.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener commented on a diff in pull request #14499: [Enhancement](fe) replace assertTrue(X.equals(X)) with assertEquals (11916)
Posted by GitBox <gi...@apache.org>.
jackwener commented on code in PR #14499:
URL: https://github.com/apache/doris/pull/14499#discussion_r1056955764
##########
fe/fe-core/src/test/java/org/apache/doris/persist/DropAndRecoverInfoTest.java:
##########
@@ -101,6 +102,7 @@ public void testRecoveryInfoSerialization() throws Exception {
Assert.assertEquals("a", rInfo1.getNewDbName());
Assert.assertEquals("b", rInfo1.getNewTableName());
Assert.assertEquals("c", rInfo1.getNewPartitionName());
+>>>>>>> origin/master:fe/fe-core/src/test/java/org/apache/doris/persist/DropAndRecoverInfoTest.java
Review Comment:
forgot to remove?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] priyasharma1 closed pull request #14499: [Enhancement](fe) replace assertTrue(X.equals(X)) with assertEquals (11916)
Posted by GitBox <gi...@apache.org>.
priyasharma1 closed pull request #14499: [Enhancement](fe) replace assertTrue(X.equals(X)) with assertEquals (11916)
URL: https://github.com/apache/doris/pull/14499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org